Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2834573003: [Media Router] Remove duplicate entries in BUILD (Closed)

Created:
3 years, 8 months ago by takumif
Modified:
3 years, 8 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove duplicate entries in BUILD These seven Media Router unit test files were listed both in chrome/test/BUILD.gn and chrome/common/media_router/BUILD.gn. This CL removes them from the latter. BUG=704958 Review-Url: https://codereview.chromium.org/2834573003 Cr-Commit-Position: refs/heads/master@{#466125} Committed: https://chromium.googlesource.com/chromium/src/+/cd90c4719b46692c8eee8279cf1dc8894356845a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/common/media_router/BUILD.gn View 1 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
takumif
Please take a look, thanks!
3 years, 8 months ago (2017-04-20 18:22:45 UTC) #4
imcheng
lgtm https://codereview.chromium.org/2834573003/diff/1/chrome/common/media_router/BUILD.gn File chrome/common/media_router/BUILD.gn (right): https://codereview.chromium.org/2834573003/diff/1/chrome/common/media_router/BUILD.gn#newcode1 chrome/common/media_router/BUILD.gn:1: # Copyright 2017 The Chrounit_testsmium Authors. All rights ...
3 years, 8 months ago (2017-04-20 18:41:03 UTC) #5
takumif
https://codereview.chromium.org/2834573003/diff/1/chrome/common/media_router/BUILD.gn File chrome/common/media_router/BUILD.gn (right): https://codereview.chromium.org/2834573003/diff/1/chrome/common/media_router/BUILD.gn#newcode1 chrome/common/media_router/BUILD.gn:1: # Copyright 2017 The Chrounit_testsmium Authors. All rights reserved. ...
3 years, 8 months ago (2017-04-20 19:05:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834573003/20001
3 years, 8 months ago (2017-04-20 20:53:00 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:59:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd90c4719b46692c8eee8279cf1d...

Powered by Google App Engine
This is Rietveld 408576698