Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2834563002: Only test SpecialStoragePolicy->IsOriginSessionOnly for temporary storage (Closed)

Created:
3 years, 8 months ago by michaeln
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only test SpecialStoragePolicy->IsOriginSessionOnly for temporary storage The attribute doesn't apply to other types and this also avoid calling into the ExtensionSpecialStoragePolicy prior to the extension system being fully initialized. BUG=713353 Review-Url: https://codereview.chromium.org/2834563002 Cr-Commit-Position: refs/heads/master@{#466097} Committed: https://chromium.googlesource.com/chromium/src/+/79743d6711cd3e10938f7a7fb057dd065dca3822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M storage/browser/quota/quota_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
michaeln
ptal
3 years, 8 months ago (2017-04-20 00:11:44 UTC) #4
xiyuan
lgtm Thanks for the quick fix. The problem go away with this CL.
3 years, 8 months ago (2017-04-20 14:54:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834563002/1
3 years, 8 months ago (2017-04-20 19:51:58 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 19:56:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/79743d6711cd3e10938f7a7fb057...

Powered by Google App Engine
This is Rietveld 408576698