Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2834543007: Give consistent names to subgroups of ComputedStyle. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, nainar
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Give consistent names to subgroups of ComputedStyle. ComputedStyle has several DataRef members that are named inconsistently. This patch changes the following names: - surround_ -> surround_data_ - box_ -> box_data_ - visual_ -> visual_data_ - background_ -> background_data_ This makes the members consistent, so that they can be easily generated. BUG=628043 Review-Url: https://codereview.chromium.org/2834543007 Cr-Commit-Position: refs/heads/master@{#467189} Committed: https://chromium.googlesource.com/chromium/src/+/cb7ad92fe2a8bd9561264169b6765c75e82eea23

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -183 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 22 chunks +167 lines, -139 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 12 chunks +45 lines, -44 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
shend
Hi Naina, PTAL
3 years, 8 months ago (2017-04-21 06:41:57 UTC) #3
nainar
lgtm
3 years, 8 months ago (2017-04-21 06:44:54 UTC) #6
shend
Hi Eddy, PTAL
3 years, 8 months ago (2017-04-23 22:13:32 UTC) #10
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-24 07:10:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834543007/20001
3 years, 8 months ago (2017-04-25 22:53:02 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 00:59:49 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb7ad92fe2a8bd9561264169b676...

Powered by Google App Engine
This is Rietveld 408576698