Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issue 2834543004: policy_templates.json: Harmonize names for non-translatable strings (Closed)

Created:
3 years, 8 months ago by Thiemo Nagel
Modified:
3 years, 8 months ago
Reviewers:
emaxx
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

policy_templates.json: Harmonize names for non-translatable strings BUG=none Review-Url: https://codereview.chromium.org/2834543004 Cr-Commit-Position: refs/heads/master@{#466293} Committed: https://chromium.googlesource.com/chromium/src/+/a32c512b142f361e74832906b12574ce6f0b46db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M components/policy/resources/policy_templates.json View 24 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Thiemo Nagel
This is hopefully the last in the policy_templates.json series... -- could you please take a ...
3 years, 8 months ago (2017-04-20 16:26:28 UTC) #4
emaxx
LGTM. Thanks for these efforts on cleaning up policy_templates!
3 years, 8 months ago (2017-04-20 17:12:43 UTC) #7
Thiemo Nagel
> Thanks for these efforts on cleaning up policy_templates! Thanks for your patient reviews!
3 years, 8 months ago (2017-04-21 09:13:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834543004/1
3 years, 8 months ago (2017-04-21 09:14:06 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 09:18:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a32c512b142f361e74832906b125...

Powered by Google App Engine
This is Rietveld 408576698