Copy dbghelp.dll to output directory

Copy dbghelp.dll to output directory

Chrome's tests sometimes symbolize call stacks. In order to support new
PDB formats such as PDB's generated by VS 2017's updated /debug:fastlink
we need to use a recent version of dbghelp.dll. This change restores a
modified version of _CopyDebugger that was removed a few weeks ago, thus
avoiding a CPU busy hang in the system version of dbghelp.dll.

R=jochen@chromium.org
BUG=712905
Review-Url: https://codereview.chromium.org/2834513003
Cr-Commit-Position: refs/heads/master@{#465784}
Committed: https://chromium.googlesource.com/chromium/src/+/6db4113f95a5fd90ec2e0df495ba1982c651ccee

[brucedawson, 2017-04-19 19:56:44]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 19:57:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-04-19 20:39:26]

Description was changed from

==========
Copy dbghelp.dll to output directory

Chrome's tests sometimes symbolize call stacks. In order to support new
PDB formats such as PDB's generated by VS 2017's updated /debug:fastlink
we need to use a recent version of dbghelp.dll. This change restores a
modified version of _CopyDebugger that was removed a few weeks ago.

R=jochen@chromium.org
BUG=712905
==========

to

==========
Copy dbghelp.dll to output directory

Chrome's tests sometimes symbolize call stacks. In order to support new
PDB formats such as PDB's generated by VS 2017's updated /debug:fastlink
we need to use a recent version of dbghelp.dll. This change restores a
modified version of _CopyDebugger that was removed a few weeks ago, thus
avoiding a CPU busy hang in the system version of dbghelp.dll.

R=jochen@chromium.org
BUG=712905
==========

[brucedawson, 2017-04-19 20:40:13]

PTAL.

I retained the basic structure of the code from before it was removed, to keep
the change simple, and because it seemed reasonable enough. The main change is
to only copy dbghelp.dll, and changing the comment.

[jochen (gone - plz use gerrit), 2017-04-19 20:43:29]

lgtm

[commit-bot: I haz the power, 2017-04-19 21:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 21:36:58]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-04-19 22:18:47]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:19:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:27:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492640327060840, "parent_rev":
"211430bf1dc94f392d736cd02a3eed95b9f6dfaa", "commit_rev":
"6db4113f95a5fd90ec2e0df495ba1982c651ccee"}

[commit-bot: I haz the power, 2017-04-19 22:27:53]

Description was changed from

==========
Copy dbghelp.dll to output directory

Chrome's tests sometimes symbolize call stacks. In order to support new
PDB formats such as PDB's generated by VS 2017's updated /debug:fastlink
we need to use a recent version of dbghelp.dll. This change restores a
modified version of _CopyDebugger that was removed a few weeks ago, thus
avoiding a CPU busy hang in the system version of dbghelp.dll.

R=jochen@chromium.org
BUG=712905
==========

to

==========
Copy dbghelp.dll to output directory

Chrome's tests sometimes symbolize call stacks. In order to support new
PDB formats such as PDB's generated by VS 2017's updated /debug:fastlink
we need to use a recent version of dbghelp.dll. This change restores a
modified version of _CopyDebugger that was removed a few weeks ago, thus
avoiding a CPU busy hang in the system version of dbghelp.dll.

R=jochen@chromium.org
BUG=712905

Review-Url: https://codereview.chromium.org/2834513003
Cr-Commit-Position: refs/heads/master@{#465784}
Committed:
https://chromium.googlesource.com/chromium/src/+/6db4113f95a5fd90ec2e0df495ba...
==========

[commit-bot: I haz the power, 2017-04-19 22:27:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6db4113f95a5fd90ec2e0df495ba...