Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2834493008: Fix null pointer dereference in ipc_boostrap (Closed)

Created:
3 years, 8 months ago by Charlie Harrison
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null pointer dereference in ipc_boostrap This was being hit when a sync message is dequeued and handled, and the receiver endpoint immediately destroys itself. BUG=714192 Review-Url: https://codereview.chromium.org/2834493008 Cr-Commit-Position: refs/heads/master@{#466383} Committed: https://chromium.googlesource.com/chromium/src/+/1af8d6abdae50ae8b8df88c7796a9d042461b4d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ipc/ipc_mojo_bootstrap.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Charlie Harrison
Ken, would you PTAL? I was hitting this issue in the window.open CL (which will ...
3 years, 8 months ago (2017-04-21 15:24:59 UTC) #5
Ken Rockot(use gerrit already)
Oof, nice catch. LGTM and thanks!
3 years, 8 months ago (2017-04-21 17:39:12 UTC) #8
Charlie Harrison
Thanks, I'll go ahead and land this but we should open up a bug to ...
3 years, 8 months ago (2017-04-21 17:41:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834493008/1
3 years, 8 months ago (2017-04-21 17:41:52 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 17:47:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1af8d6abdae50ae8b8df88c7796a...

Powered by Google App Engine
This is Rietveld 408576698