MacViews: Allows the toolkit-views Zoom Dialog to be used

chrome/browser/ui/browser_dialogs.h

Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index 11f69150304727ff44649c760d7501681f4097ec..1f6b342c24d10d5eaa9e441ed48617a36a92241b 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -133,6 +133,21 @@ void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,
                                     const GURL& url,
                                     bool newly_bookmarked);
 
+// Shows a views zoom bubble at the | anchor_point|. This occurs when the zoom

[msw, 2017/04/24 18:53:38]

nit: no space inside vertical bars

[varkha, 2017/04/26 04:52:59]

Done.

+// icon is clicked or or via a key equivalent.

[msw, 2017/04/24 18:53:38]

nit: "or or", consider "or when a shortcut key is pressed."
(it's ok to leave "or via a key shortcut" to match above)

[varkha, 2017/04/26 04:52:59]

Done.

+void ShowZoomBubbleViewsAtPoint(content::WebContents* web_contents,
+                                const gfx::Point& anchor_point,
+                                bool user_action);
+
+// Closes a views zoom bubble if currently shown.
+void CloseZoomBubbleViews();
+
+// Refreshes views zoom bubble if currently shown.
+void RefreshZoomBubbleViews();

[msw, 2017/04/24 18:53:38]

aside: not for this CL, but it would be nice to minimize and standardize the
APIs across various dialogs. Ideally we'd just have Show*() and Get*() plus
per-dialog methods like ZoomBubbleView::Refresh (& GetWidget + Widget::Close).

[varkha, 2017/04/26 04:52:59]

Acknowledged. We would need to move the declarations of per-dialog methods to an
interface in a file outside of chrome/browser/ui/views as that cannot be used
(see chrome/browser/ui/cocoa/DEPS). Yes it would be better to do that for all
such bridge methods at once.

+
+// Returns true if views zoom bubble is currently shown.
+bool IsZoomBubbleViewsShown();
+
 // Bridging methods that show/hide the toolkit-views based Task Manager on Mac.
 task_manager::TaskManagerTableModel* ShowTaskManagerViews(Browser* browser);
 void HideTaskManagerViews();