MacViews: Allows the toolkit-views Zoom Dialog to be used

chrome/browser/ui/browser_dialogs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 115 matching lines @@
 // Show a Views bookmark bubble at the given point. This occurs when the
 // bookmark star is clicked or "Bookmark This Page..." is selected from a menu
 // or via a key equivalent.
 void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,
                                     gfx::NativeView parent,
                                     bookmarks::BookmarkBubbleObserver* observer,
                                     Browser* browser,
                                     const GURL& url,
                                     bool newly_bookmarked);
 
+// Shows a views zoom bubble at the | anchor_point|. This occurs when the zoom

[msw, 2017/04/24 18:53:38]

nit: no space inside vertical bars

[varkha, 2017/04/26 04:52:59]

Done.

+// icon is clicked or or via a key equivalent.

[msw, 2017/04/24 18:53:38]

nit: "or or", consider "or when a shortcut key is pressed."
(it's ok to leave "or via a key shortcut" to match above)

[varkha, 2017/04/26 04:52:59]

Done.

+void ShowZoomBubbleViewsAtPoint(content::WebContents* web_contents,
+                                const gfx::Point& anchor_point,
+                                bool user_action);
+
+// Closes a views zoom bubble if currently shown.
+void CloseZoomBubbleViews();
+
+// Refreshes views zoom bubble if currently shown.
+void RefreshZoomBubbleViews();

[msw, 2017/04/24 18:53:38]

aside: not for this CL, but it would be nice to minimize and standardize the
APIs across various dialogs. Ideally we'd just have Show*() and Get*() plus
per-dialog methods like ZoomBubbleView::Refresh (& GetWidget + Widget::Close).

[varkha, 2017/04/26 04:52:59]

Acknowledged. We would need to move the declarations of per-dialog methods to an
interface in a file outside of chrome/browser/ui/views as that cannot be used
(see chrome/browser/ui/cocoa/DEPS). Yes it would be better to do that for all
such bridge methods at once.

+
+// Returns true if views zoom bubble is currently shown.
+bool IsZoomBubbleViewsShown();
+
 // Bridging methods that show/hide the toolkit-views based Task Manager on Mac.
 task_manager::TaskManagerTableModel* ShowTaskManagerViews(Browser* browser);
 void HideTaskManagerViews();
 
 // Show the Views "Chrome Update" dialog.
 void ShowUpdateChromeDialogViews(gfx::NativeWindow parent);
 
 #endif  // OS_MACOSX
 
 #if defined(TOOLKIT_VIEWS)
@@ skipping 95 matching lines @@
 using BubbleShowPtr =
     void (*)(content::WebContents*,
              const std::vector<arc::ArcNavigationThrottle::AppInfo>&,
              const IntentPickerResponse&);
 
 BubbleShowPtr ShowIntentPickerBubble();
 
 #endif  // OS_CHROMEOS
 
 #endif  // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_