Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2834493004: Convert constructor/audiobuffersource.html to use new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert constructor/audiobuffersource.html to use new Audit Manually converted to use new Audit. BUG=704967 TEST=constructor/audiobuffersource.html Review-Url: https://codereview.chromium.org/2834493004 Cr-Commit-Position: refs/heads/master@{#466466} Committed: https://chromium.googlesource.com/chromium/src/+/1267653f549c626251458a862c84797d702f4bd4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -111 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html View 1 2 3 3 chunks +65 lines, -111 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-21 16:01:26 UTC) #2
hongchan
lgtm with nits https://codereview.chromium.org/2834493004/diff/40001/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html File third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html (right): https://codereview.chromium.org/2834493004/diff/40001/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html#newcode14 third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html:14: var context; Please change all var ...
3 years, 8 months ago (2017-04-21 20:48:51 UTC) #3
Raymond Toy
https://codereview.chromium.org/2834493004/diff/40001/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html File third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html (right): https://codereview.chromium.org/2834493004/diff/40001/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html#newcode14 third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html:14: var context; On 2017/04/21 20:48:51, hongchan wrote: > Please ...
3 years, 8 months ago (2017-04-21 20:54:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834493004/60001
3 years, 8 months ago (2017-04-21 20:55:41 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 22:21:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1267653f549c626251458a862c84...

Powered by Google App Engine
This is Rietveld 408576698