Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2834493002: Remove vibrate w/o user gesture by default (Closed)

Created:
3 years, 8 months ago by Bin Lu
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, lunalu1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove vibrate w/o user gesture by default. Change the flag from "experimental" to "stable" and from 'DISABLED_BY_DEFAULT' TO 'ENABLED_BY_DEFAULT': Calls to navigator.vibrate will return 'false' if user hasn't tapped on the frame or any embedded frame yet. This is for M60 since M59 had branched last week, and the previous CL has been merged to M59: https://bugs.chromium.org/p/chromium/issues/detail?id=704650#c12. The Intent to Deprecate & Remove thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 Review-Url: https://codereview.chromium.org/2834493002 Cr-Commit-Position: refs/heads/master@{#466768} Committed: https://chromium.googlesource.com/chromium/src/+/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc

Patch Set 1 #

Patch Set 2 : Change to turn on by default #

Messages

Total messages: 18 (12 generated)
binlu
Does this LG? Thanks.
3 years, 8 months ago (2017-04-19 19:07:33 UTC) #6
binlu
Friendly ping.
3 years, 8 months ago (2017-04-21 14:31:55 UTC) #10
jochen (gone - plz use gerrit)
I'm not sure why, but the codereview UI didn't show this CL as requiring action ...
3 years, 8 months ago (2017-04-21 14:40:15 UTC) #11
binlu
On 2017/04/21 14:40:15, jochen (slow until May 2) wrote: > I'm not sure why, but ...
3 years, 8 months ago (2017-04-24 19:51:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834493002/20001
3 years, 8 months ago (2017-04-24 19:53:39 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 21:20:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e66f2ff1ce2c15bb342ad8dd7579...

Powered by Google App Engine
This is Rietveld 408576698