Description was changed from ========== Turn on the removal of vibrate w/o user gesture by ...
3 years, 8 months ago
(2017-04-19 18:50:07 UTC)
#3
Description was changed from
==========
Turn on the removal of vibrate w/o user gesture by default.
Calls to navigator.vibrate will return 'false' if user hasn't tapped on the
frame or any embedded frame yet. Change the flag from "experimental" to
"stable" and from 'DISABLED_BY_DEFAULT' TO 'ENABLED_BY_DEFAULT'.
This is for M60 since M59 had branched last week.
The Intent to Deprecate & Remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik
BUG=704650
==========
to
==========
Remove vibrate w/o user gesture by default.
Calls to navigator.vibrate will return 'false' if user hasn't tapped on the
frame or any embedded frame yet. Change the flag from "experimental" to "stable"
and from 'DISABLED_BY_DEFAULT' TO 'ENABLED_BY_DEFAULT'. This is for M60 since
M59 had branched last week, and the previous CL has been merged to M59:
https://bugs.chromium.org/p/chromium/issues/detail?id=704650#c12.
The Intent to Deprecate & Remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik
BUG=704650
==========
3 years, 8 months ago
(2017-04-19 20:26:35 UTC)
#8
Dry run: This issue passed the CQ dry run.
binlu
Description was changed from ========== Remove vibrate w/o user gesture by default. Calls to navigator.vibrate ...
3 years, 8 months ago
(2017-04-21 14:31:31 UTC)
#9
Description was changed from
==========
Remove vibrate w/o user gesture by default.
Calls to navigator.vibrate will return 'false' if user hasn't tapped on the
frame or any embedded frame yet. Change the flag from "experimental" to "stable"
and from 'DISABLED_BY_DEFAULT' TO 'ENABLED_BY_DEFAULT'. This is for M60 since
M59 had branched last week, and the previous CL has been merged to M59:
https://bugs.chromium.org/p/chromium/issues/detail?id=704650#c12.
The Intent to Deprecate & Remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik
BUG=704650
==========
to
==========
Remove vibrate w/o user gesture by default.
Change the flag from "experimental" to "stable" and from 'DISABLED_BY_DEFAULT'
TO 'ENABLED_BY_DEFAULT': Calls to navigator.vibrate will return 'false' if user
hasn't tapped on the frame or any embedded frame yet.
This is for M60 since M59 had branched last week, and the previous CL has been
merged to M59:
https://bugs.chromium.org/p/chromium/issues/detail?id=704650#c12.
The Intent to Deprecate & Remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik
BUG=704650
==========
binlu
Friendly ping.
3 years, 8 months ago
(2017-04-21 14:31:55 UTC)
#10
Friendly ping.
jochen (gone - plz use gerrit)
I'm not sure why, but the codereview UI didn't show this CL as requiring action ...
3 years, 8 months ago
(2017-04-21 14:40:15 UTC)
#11
I'm not sure why, but the codereview UI didn't show this CL as requiring action
from me :/
anyways, lgtm
binlu
On 2017/04/21 14:40:15, jochen (slow until May 2) wrote: > I'm not sure why, but ...
3 years, 8 months ago
(2017-04-24 19:51:07 UTC)
#12
On 2017/04/21 14:40:15, jochen (slow until May 2) wrote:
> I'm not sure why, but the codereview UI didn't show this CL as requiring
action
> from me :/
>
> anyways, lgtm
Thanks Jochen for the review. Submitting now.
Bin Lu
The CQ bit was checked by binlu@google.com
3 years, 8 months ago
(2017-04-24 19:52:41 UTC)
#13
Issue 2834493002: Remove vibrate w/o user gesture by default
(Closed)
Created 3 years, 8 months ago by Bin Lu
Modified 3 years, 8 months ago
Reviewers: jochen (gone - plz use gerrit), binlu, ojan, Rick Byers
Base URL:
Comments: 0