third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp - Issue 2834463002: Move CreateDOMException out of V8ThrowException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp

Issue 2834463002: Move CreateDOMException out of V8ThrowException (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h ('K') | « third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp b/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp

index 14555055d149bf39178f45f59d2c6428528ab55d..e1e03f3c5acda64a0f4296b76dd1ce3d5997d73b 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp

+++ b/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp

@@ -8,7 +8,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptPromiseResolver.h"

#include "bindings/core/v8/ScriptState.h"

-#include "bindings/core/v8/V8ThrowException.h"

+#include "bindings/core/v8/V8ThrowDOMException.h"

#include "core/dom/DOMException.h"

#include "core/dom/DOMTypedArray.h"

#include "core/dom/ExceptionCode.h"

@@ -263,7 +263,7 @@ void SetMediaKeysHandler::Fail(ExceptionCode code,

// Reject promise with an appropriate error.

ScriptState::Scope scope(GetScriptState());

v8::Isolate* isolate = GetScriptState()->GetIsolate();

- Reject(V8ThrowException::CreateDOMException(isolate, code, error_message));

+ Reject(V8ThrowDOMException::CreateDOMException(isolate, code, error_message));

}

void SetMediaKeysHandler::ClearFailed(ExceptionCode code,