Download Home : Remove drawer UI

chrome/android/java/res/layout/download_manager_ui_space_widget.xml

Index: chrome/android/java/res/layout/download_manager_ui_space_widget.xml
diff --git a/chrome/android/java/res/layout/download_manager_ui_space_widget.xml b/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
index a963bbf06f93dba924b422522049adfac983de57..d28de89284e1820aa3e22d854bb514f5f75975df 100644
--- a/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
+++ b/chrome/android/java/res/layout/download_manager_ui_space_widget.xml
@@ -3,56 +3,52 @@
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
-<merge xmlns:android="http://schemas.android.com/apk/res/android"
-        xmlns:chrome="http://schemas.android.com/apk/res-auto" >
-
-    <!-- Widget style adapted from the UX spec:
-         https://bugs.chromium.org/p/chromium/issues/detail?id=658246&desc=2#c18
-    -->
-    <LinearLayout
+<LinearLayout
+        xmlns:android="http://schemas.android.com/apk/res/android"
+        xmlns:chrome="http://schemas.android.com/apk/res-auto"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:paddingStart="@dimen/downloads_item_margin"
+        android:paddingEnd="@dimen/downloads_item_margin"
+        android:paddingTop="26dp"
+        android:paddingBottom="6dp"
+        android:orientation="vertical" >
+
+    <TextView
+            android:id="@+id/size_downloaded"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:layout_marginStart="@dimen/drawer_margin_large"
-            android:layout_marginEnd="@dimen/drawer_margin_large"
-            android:paddingTop="26dp"
-            android:paddingBottom="24dp"
-            android:orientation="vertical" >
-
-        <TextView
-                android:id="@+id/size_downloaded"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:singleLine="true"
-                android:textColor="@color/light_active_color"
-                android:textSize="20sp" />
-
-        <!-- The progress bar uses 32dp of space, vertically, including spacing. -->
-        <org.chromium.chrome.browser.widget.MaterialProgressBar
-                android:id="@+id/space_bar"
-                android:layout_width="match_parent"
-                android:layout_height="4dp"
-                android:layout_marginTop="14dp"
-                android:layout_marginBottom="14dp"
-                chrome:colorBackground="@color/google_grey_400"
-                chrome:colorProgress="@color/light_active_color"
-                chrome:colorSecondaryProgress="@color/google_grey_600" />
-
-        <TextView
-                android:id="@+id/size_other_apps"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:singleLine="true"
-                android:textColor="@color/google_grey_600"
-                android:textSize="12sp" />
-
-        <TextView
-                android:id="@+id/size_free"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:singleLine="true"
-                android:textColor="@color/google_grey_400"
-                android:textSize="12sp" />
+            android:singleLine="true"
+            android:textColor="@color/google_blue_500"
+            android:textSize="16sp"
+            android:textStyle="bold" />
+
+    <!-- The progress bar uses 20dp of space, vertically, including spacing. -->
+    <org.chromium.chrome.browser.widget.MaterialProgressBar
+            android:id="@+id/space_bar"
+            android:layout_width="match_parent"
+            android:layout_height="4dp"
+            android:layout_marginTop="8dp"
+            android:layout_marginBottom="8dp"
+            android:layout_marginEnd="-2dp"

[Theresa, 2017/04/24 20:48:17]

Why does these need -2dp margin end?

Will you please upload a couple of screenshots to the bug?

[shaktisahu, 2017/04/24 22:07:09]

Attached screenshots. The margin in the spec is 14dp while the margin of the
containing Linearlayout is downloads_item_margin, i.e. 16dp.
So I needed -2dp here. Let me know if you think we have to tweak this.

[Theresa, 2017/04/24 22:45:15]

Let's just change the LinearLayout margin to 14dp.

[shaktisahu, 2017/04/25 21:14:26]

Done.

+            chrome:colorBackground="@color/black_24"
+            chrome:colorProgress="@color/google_blue_500"
+            chrome:colorSecondaryProgress="@color/space_display_text" />
+
+    <TextView
+            android:id="@+id/size_other_apps"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:singleLine="true"
+            android:textColor="@color/space_display_text"
+            android:textSize="14sp" />
 
-    </LinearLayout>
+    <TextView
+            android:id="@+id/size_free"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:singleLine="true"
+            android:textColor="@color/black_54"
+            android:textSize="14sp" />
 
-</merge>
+</LinearLayout>