chrome/android/java/res/layout/download_manager_ui_space_widget.xml - Issue 2834453007: Download Home : Remove drawer UI

Side by Side Diff: chrome/android/java/res/layout/download_manager_ui_space_widget.xml

Issue 2834453007: Download Home : Remove drawer UI (Closed)

Patch Set: changes for tablets Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/android/java/res/layout/download_main.xml ('K') | « chrome/android/java/res/layout/download_manager_ui_drawer_filter.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | chrome/android/java/res/values/colors.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <merge xmlns:android="http://schemas.android.com/apk/res/android"	6 <LinearLayout

7 xmlns:chrome="http://schemas.android.com/apk/res-auto" >	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:paddingStart="@dimen/downloads_item_margin"

	12 android:paddingEnd="@dimen/downloads_item_margin"

	13 android:paddingTop="26dp"

	14 android:paddingBottom="6dp"

	15 android:orientation="vertical" >

8	16

9 <!-- Widget style adapted from the UX spec:	17 <TextView

10 https://bugs.chromium.org/p/chromium/issues/detail?id=658246&desc=2#c18	18 android:id="@+id/size_downloaded"

11 -->

12 <LinearLayout

13 android:layout_width="match_parent"	19 android:layout_width="match_parent"

14 android:layout_height="wrap_content"	20 android:layout_height="wrap_content"

15 android:layout_marginStart="@dimen/drawer_margin_large"	21 android:singleLine="true"

16 android:layout_marginEnd="@dimen/drawer_margin_large"	22 android:textColor="@color/google_blue_500"

17 android:paddingTop="26dp"	23 android:textSize="16sp"

18 android:paddingBottom="24dp"	24 android:textStyle="bold" />

19 android:orientation="vertical" >

20	25

21 <TextView	26 <!-- The progress bar uses 20dp of space, vertically, including spacing. -->

22 android:id="@+id/size_downloaded"	27 <org.chromium.chrome.browser.widget.MaterialProgressBar

23 android:layout_width="match_parent"	28 android:id="@+id/space_bar"

24 android:layout_height="wrap_content"	29 android:layout_width="match_parent"

25 android:singleLine="true"	30 android:layout_height="4dp"

26 android:textColor="@color/light_active_color"	31 android:layout_marginTop="8dp"

27 android:textSize="20sp" />	32 android:layout_marginBottom="8dp"

	33 android:layout_marginEnd="-2dp"
	Theresa 2017/04/24 20:48:17 Why does these need -2dp margin end? Will you ple Why does these need -2dp margin end? Will you please upload a couple of screenshots to the bug? shaktisahu 2017/04/24 22:07:09 Attached screenshots. The margin in the spec is 14 Show quoted text On 2017/04/24 20:48:17, Theresa wrote: > Why does these need -2dp margin end? > > Will you please upload a couple of screenshots to the bug? Attached screenshots. The margin in the spec is 14dp while the margin of the containing Linearlayout is downloads_item_margin, i.e. 16dp. So I needed -2dp here. Let me know if you think we have to tweak this. Theresa 2017/04/24 22:45:15 Let's just change the LinearLayout margin to 14dp. Show quoted text On 2017/04/24 22:07:09, shaktisahu wrote: > On 2017/04/24 20:48:17, Theresa wrote: > > Why does these need -2dp margin end? > > > > Will you please upload a couple of screenshots to the bug? > > Attached screenshots. The margin in the spec is 14dp while the margin of the > containing Linearlayout is downloads_item_margin, i.e. 16dp. > So I needed -2dp here. Let me know if you think we have to tweak this. Let's just change the LinearLayout margin to 14dp. shaktisahu 2017/04/25 21:14:26 Done. Show quoted text On 2017/04/24 22:45:15, Theresa wrote: > On 2017/04/24 22:07:09, shaktisahu wrote: > > On 2017/04/24 20:48:17, Theresa wrote: > > > Why does these need -2dp margin end? > > > > > > Will you please upload a couple of screenshots to the bug? > > > > Attached screenshots. The margin in the spec is 14dp while the margin of the > > containing Linearlayout is downloads_item_margin, i.e. 16dp. > > So I needed -2dp here. Let me know if you think we have to tweak this. > > Let's just change the LinearLayout margin to 14dp. Done.
	34 chrome:colorBackground="@color/black_24"

	35 chrome:colorProgress="@color/google_blue_500"

	36 chrome:colorSecondaryProgress="@color/space_display_text" />

28	37

29 <!-- The progress bar uses 32dp of space, vertically, including spacing. -->	38 <TextView

30 <org.chromium.chrome.browser.widget.MaterialProgressBar	39 android:id="@+id/size_other_apps"

31 android:id="@+id/space_bar"	40 android:layout_width="match_parent"

32 android:layout_width="match_parent"	41 android:layout_height="wrap_content"

33 android:layout_height="4dp"	42 android:singleLine="true"

34 android:layout_marginTop="14dp"	43 android:textColor="@color/space_display_text"

35 android:layout_marginBottom="14dp"	44 android:textSize="14sp" />

36 chrome:colorBackground="@color/google_grey_400"

37 chrome:colorProgress="@color/light_active_color"

38 chrome:colorSecondaryProgress="@color/google_grey_600" />

39	45

40 <TextView	46 <TextView

41 android:id="@+id/size_other_apps"	47 android:id="@+id/size_free"

42 android:layout_width="match_parent"	48 android:layout_width="match_parent"

43 android:layout_height="wrap_content"	49 android:layout_height="wrap_content"

44 android:singleLine="true"	50 android:singleLine="true"

45 android:textColor="@color/google_grey_600"	51 android:textColor="@color/black_54"

46 android:textSize="12sp" />	52 android:textSize="14sp" />

47	53

48 <TextView	54 </LinearLayout>

49 android:id="@+id/size_free"

50 android:layout_width="match_parent"

51 android:layout_height="wrap_content"

52 android:singleLine="true"

53 android:textColor="@color/google_grey_400"

54 android:textSize="12sp" />

55

56 </LinearLayout>

57

58 </merge>

OLD	NEW