Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2834373003: rpcexplorer: change rootPath property (Closed)

Created:
3 years, 8 months ago by nodir
Modified:
3 years, 8 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org, emso
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

rpcexplorer: change rootPath property Polymer has introduced a property called "rootPath" which clashes with the rootPath used by RPC Explorer. Rename rootPath to explorerRootPath. BUG= Review-Url: https://codereview.chromium.org/2834373003 Committed: https://github.com/luci/luci-go/commit/d51ca3c7990d40783d77879bc9de8bd22eeb294b

Patch Set 1 #

Patch Set 2 : .keep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M server/static/rpcexplorer/index.html View 1 chunk +1 line, -1 line 0 comments Download
M server/static/rpcexplorer/rpc-explorer.html View 4 chunks +9 lines, -9 lines 0 comments Download
M web/apps/rpcexplorer/index.html View 1 chunk +1 line, -1 line 0 comments Download
M web/inc/rpcexplorer/rpc-explorer.html View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nodir
PTAL
3 years, 8 months ago (2017-04-24 21:07:13 UTC) #2
dnj
lgtm
3 years, 8 months ago (2017-04-24 21:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834373003/20001
3 years, 8 months ago (2017-04-24 21:54:03 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:00:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/d51ca3c7990d40783d77879bc9de8bd22eeb294b

Powered by Google App Engine
This is Rietveld 408576698