Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2834363003: [inspector] console property should be enumerable (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman, gsathya
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] console property should be enumerable BUG=chromium:714486 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2834363003 Cr-Commit-Position: refs/heads/master@{#44873} Committed: https://chromium.googlesource.com/v8/v8/+/70e58e70cbf0b2be2f68840c6adbf653afb1e277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -24 lines) Patch
M src/bootstrapper.cc View 1 chunk +36 lines, -24 lines 0 comments Download
M test/inspector/runtime/console-spec.js View 1 chunk +7 lines, -0 lines 0 comments Download
M test/inspector/runtime/console-spec-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kozy
Dmitry, please take a look! I prefer not to revert original CL since I landed ...
3 years, 8 months ago (2017-04-24 19:03:51 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2017-04-25 20:30:45 UTC) #2
kozy
Sathya, please take a look. I need owner lgtm for bootstrapper.cc.
3 years, 8 months ago (2017-04-25 20:49:19 UTC) #4
gsathya
On 2017/04/25 20:49:19, kozy wrote: > Sathya, please take a look. > I need owner ...
3 years, 8 months ago (2017-04-25 21:49:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834363003/1
3 years, 8 months ago (2017-04-25 21:51:25 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 22:17:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/70e58e70cbf0b2be2f68840c6adbf653afb...

Powered by Google App Engine
This is Rietveld 408576698