Issue 2834343002: Make InputMethodController::TextInputType() to use canonicalized position

yosin_UTC9

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

3 years, 8 months ago (2017-04-24 06:13:27 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834343002/1

3 years, 8 months ago (2017-04-24 06:13:38 UTC) #2

yosin_UTC9

Description was changed from ========== 2017-04-24T15:09:42 2017-04-24T15:09:31 BUG= ========== to ========== Make InputMethodController::TextInputType() to use ...

3 years, 8 months ago (2017-04-24 06:14:40 UTC) #3

yosin_UTC9

Description was changed from ========== Make InputMethodController::TextInputType() to use canonicalized position ... BUG=711396, 712761, 714507 ...

3 years, 8 months ago (2017-04-24 07:17:37 UTC) #4

yosin_UTC9

yosin@chromium.org changed reviewers: + tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

3 years, 8 months ago (2017-04-24 07:17:37 UTC) #5

yosin_UTC9

PTAL This patch fixes ReleaseBlock-Beta. I would like to land this patch today to unblock ...

3 years, 8 months ago (2017-04-24 07:21:16 UTC) #6

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 8 months ago (2017-04-24 08:24:59 UTC) #7

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 8 months ago (2017-04-24 08:25:00 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834343002/1

3 years, 8 months ago (2017-04-24 09:35:36 UTC) #11

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493026528908770, "parent_rev": "2fc4a74de010301a7266b3bf5d5f28b45604d544", "commit_rev": "f0600844152acd9e12e486ecfd49ae492f67517c"}

3 years, 8 months ago (2017-04-24 09:38:51 UTC) #12

commit-bot: I haz the power

Description was changed from ========== Make InputMethodController::TextInputType() to use canonicalized position Make InputMethodController::TextInputType() to use ...

3 years, 8 months ago (2017-04-24 09:39:01 UTC) #13

Message was sent while issue was closed.

Description was changed from

==========
Make InputMethodController::TextInputType() to use canonicalized position

Make InputMethodController::TextInputType() to use canonicalized position

This patch changes |RootEditableElementOfSelection()| to use canonicalized
position as workaround for applications depend buggy behavior of Blink.

Before patch[1], |InputMethodController| to check editability of selection by
using |VisibleSelection::Start()|. After patch[1], |InputMethodController| to
use |SelectionInDOMTree::Base()|.

The buggy behavior of Blink caused by using |VisibleSelection::Start()| which
returns inside of editable even if scripts specified before editable.

For example, simpler version of Google Docs/Presentations:
<html>
  <head>...</head>
  <body contenteditable>...</body>
</html>

Google Docs/Presentations set selection to a position HTML@1 where before
BODY element. In this case, |VisibleSelection::Start()| == BODY@0 due by
visible position canonicalization.

[1] http://crrev.com/2782413002 Get rid of
computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController

BUG=711396, 712761, 714507
TEST=run_webkit_unit_tests
--gtest_filter=InputMethodControllerTest.TextInputTypeAtBeforeEditable
==========

to

==========
Make InputMethodController::TextInputType() to use canonicalized position

Make InputMethodController::TextInputType() to use canonicalized position

This patch changes |RootEditableElementOfSelection()| to use canonicalized
position as workaround for applications depend buggy behavior of Blink.

Before patch[1], |InputMethodController| to check editability of selection by
using |VisibleSelection::Start()|. After patch[1], |InputMethodController| to
use |SelectionInDOMTree::Base()|.

The buggy behavior of Blink caused by using |VisibleSelection::Start()| which
returns inside of editable even if scripts specified before editable.

For example, simpler version of Google Docs/Presentations:
<html>
  <head>...</head>
  <body contenteditable>...</body>
</html>

Google Docs/Presentations set selection to a position HTML@1 where before
BODY element. In this case, |VisibleSelection::Start()| == BODY@0 due by
visible position canonicalization.

[1] http://crrev.com/2782413002 Get rid of
computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController

BUG=711396, 712761, 714507
TEST=run_webkit_unit_tests
--gtest_filter=InputMethodControllerTest.TextInputTypeAtBeforeEditable

Review-Url: https://codereview.chromium.org/2834343002
Cr-Commit-Position: refs/heads/master@{#466612}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0600844152acd9e12e486ecfd49...
==========

commit-bot: I haz the power

3 years, 8 months ago (2017-04-24 09:39:02 UTC) #14

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0600844152acd9e12e486ecfd49...

Issue 2834343002: Make InputMethodController::TextInputType() to use canonicalized position (Closed)

Description

Patch Set 1 : 2017-04-24T15:09:42 #

Messages