Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2834333002: Implement all menu options functions (Closed)

Created:
3 years, 8 months ago by Leo
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement all menu options functions. 1, Call relevant native function after user selects "Always", "Never language", "Never site" 2, Translate the target/source language selected by user in Language popup menu. All functions above were tested on my local devices. This CL is based on Issue/2830543003 BUG=703887 Review-Url: https://codereview.chromium.org/2834333002 Cr-Commit-Position: refs/heads/master@{#467211} Committed: https://chromium.googlesource.com/chromium/src/+/4294989fb987c9999651d904b602d4423295c78d

Patch Set 1 #

Patch Set 2 : fix menu functions #

Total comments: 8

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java View 1 2 3 4 chunks +53 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
Leo
This issue is the implementation of all menu options.
3 years, 8 months ago (2017-04-24 07:40:59 UTC) #3
gone
https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java (right): https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java#newcode82 chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:82: private void startTransalting(int tabPostion) { salt https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java#newcode84 chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:84: // ...
3 years, 8 months ago (2017-04-24 20:14:51 UTC) #4
Leo
PTAL https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java (right): https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java#newcode82 chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:82: private void startTransalting(int tabPostion) { On 2017/04/24 20:14:51, ...
3 years, 8 months ago (2017-04-25 14:24:27 UTC) #5
gone
https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java (right): https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java#newcode82 chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:82: private void startTransalting(int tabPostion) { On 2017/04/25 14:24:27, Leo ...
3 years, 8 months ago (2017-04-25 20:19:09 UTC) #6
Leo
Thanks Dan. PTAL https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java (right): https://codereview.chromium.org/2834333002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java#newcode82 chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:82: private void startTransalting(int tabPostion) { On ...
3 years, 8 months ago (2017-04-26 00:48:00 UTC) #7
gone
lgtm
3 years, 8 months ago (2017-04-26 01:10:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834333002/60001
3 years, 8 months ago (2017-04-26 02:07:02 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 02:47:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4294989fb987c9999651d904b602...

Powered by Google App Engine
This is Rietveld 408576698