Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 2834323002: arc: kArcCompatibleFilesystemChosen pref to local state and integer. (Closed)

Created:
3 years, 8 months ago by kinaba
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

arc: kArcCompatibleFilesystemChosen pref to local state and integer. For bug 709893, It needs to be established before profile's KeyedService starts working, hence is moved to the local state which can be initialized earlier. For bug 711095, to implement a one-time UI to show the success of navigation to the user, this value needs to be tri-state (notyet, done, done-and-notified). Taking this opportunity to move to local state, this CL changes the type of the pref from boolean to integer as well. BUG=709893 BUG=711095 TEST=ChromeArcUtilTest TEST=Manually checked MediaView in Files app is working on the first run. Review-Url: https://codereview.chromium.org/2808353008 Cr-Commit-Position: refs/heads/master@{#464699} (cherry picked from commit 6ea2f510147f3bca05aea7024752e95dcf559912) Review-Url: https://codereview.chromium.org/2834323002 . Cr-Commit-Position: refs/branch-heads/3071@{#150} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/534138b6fa2d1f08dda69114567ec27cde498cd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -53 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_util.h View 3 chunks +28 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_util.cc View 5 chunks +75 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_util_unittest.cc View 8 chunks +41 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 5 chunks +7 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kinaba
3 years, 8 months ago (2017-04-24 00:47:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
534138b6fa2d1f08dda69114567ec27cde498cd0.

Powered by Google App Engine
This is Rietveld 408576698