Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2834313002: Update third_party/libva to version 1.7.1 (Closed)

Created:
3 years, 7 months ago by hiroh
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update third_party/libva to version 1.7.1 $ git clone https://github.com/01org/libva.git $ cd tmp/libva $ git checkout libva-1.7.1 $ rm -rf ~/chromium/src/third_party/libva/va $ find va -name \*.h -exec cp --parents \{\} ~/chromium/src/third_party/libva \; $ sh build/gen_version.sh . va/va_version.h.in > ~/chromium/src/third_party/libva/va/va_version.h Also Remove: - remove va/egl/va_egl.h due to the lack of license header - remove struct _VAEncMacroblockParameterBufferH264 from va/va_enc_h264.h, which contained an empty union, causing compile errors BUG=None TEST=build and test VDA and VEA on an Intel device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2834313002 Cr-Commit-Position: refs/heads/master@{#466889} Committed: https://chromium.googlesource.com/chromium/src/+/9a16f5fe06fc29a6674123b5b50ee4c58d1f09ba

Patch Set 1 #

Patch Set 2 : Update third_party/libva to version 1.7.1 and check whether the version of libva a platform support… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1126 lines, -200 lines) Patch
M media/gpu/vaapi_wrapper.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/libva/README.chromium View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/libva/va/va.h View 11 chunks +289 lines, -185 lines 0 comments Download
M third_party/libva/va/va_dec_vp9.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/libva/va/va_enc_h264.h View 2 chunks +14 lines, -1 line 0 comments Download
A third_party/libva/va/va_enc_vp9.h View 1 chunk +588 lines, -0 lines 0 comments Download
M third_party/libva/va/va_trace.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/libva/va/va_version.h View 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/libva/va/wayland/wayland-drm-client-protocol.h View 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
hiroh
3 years, 7 months ago (2017-04-24 00:01:46 UTC) #4
Alexandre Courbot
lgtm Tested on top of ChromeOS with libva 1.7.1. Libva initializes successfully as expected.
3 years, 7 months ago (2017-04-24 09:04:58 UTC) #6
Pawel Osciak
lgtm
3 years, 7 months ago (2017-04-24 09:13:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834313002/20001
3 years, 7 months ago (2017-04-25 05:08:40 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 05:28:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a16f5fe06fc29a6674123b5b50e...

Powered by Google App Engine
This is Rietveld 408576698