Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2834293002: Avoid signed/unsigned warning in VC++ 2017 builds (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid signed/unsigned warning in VC++ 2017 builds VC++ 2017's STL doesn't suppress warnings as aggressively as prior versions did. This causes warnings on code which mixes signed and unsigned types. In this case a deque of unsigned integers was being queried to see how many signed integers it contains. This could be fixed by passing in unsigned 0, 1, and 2 to std::count but changing the deque from unsigned to int is simpler. R=adamk@chromium.org BUG=chromium:683729 Review-Url: https://codereview.chromium.org/2834293002 Cr-Commit-Position: refs/heads/master@{#44814} Committed: https://chromium.googlesource.com/v8/v8/+/83c058a98cc8f4e089f8cb82b728611e323bab94

Patch Set 1 #

Patch Set 2 : Avoid signed/unsigned warning in VC++ 2017 builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/unittests/base/iterator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
brucedawson
PTAL
3 years, 8 months ago (2017-04-22 23:13:27 UTC) #5
adamk
lgtm
3 years, 8 months ago (2017-04-24 19:02:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834293002/20001
3 years, 8 months ago (2017-04-24 19:02:29 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 19:30:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/83c058a98cc8f4e089f8cb82b728611e323...

Powered by Google App Engine
This is Rietveld 408576698