Use Promises for screen.lockOrientation().

public/platform/Platform.h

Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index f2e79d66c03d00877a3b1b66682f1ed50092274a..8719bbd054a1fe29065cd74af81621532a6a02a1 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -42,7 +42,9 @@
 #include "WebGamepads.h"
 #include "WebGraphicsContext3D.h"
 #include "WebLocalizedString.h"
+#include "WebLockOrientationCallback.h"
 #include "WebScreenOrientationLockType.h"
+#include "WebScreenOrientationType.h"
 #include "WebSpeechSynthesizer.h"
 #include "WebStorageQuotaCallbacks.h"
 #include "WebStorageQuotaType.h"
@@ -634,6 +636,13 @@ public:
 
     virtual void setScreenOrientationListener(blink::WebScreenOrientationListener*) { }
     virtual void lockOrientation(WebScreenOrientationLockType) { }

[jochen (gone - plz use gerrit), 2014/05/22 08:34:35]

do you still need this one?

[mlamouri (slow - plz ping), 2014/05/22 08:58:56]

Chrome OVERRIDE this call so I need to keep this here until I remove the
OVERRIDE, right?

[jochen (gone - plz use gerrit), 2014/05/23 07:43:26]

we should not use OVERRIDE on implementations of blink API.

Please first land the content side changes (add the new method there, remove
OVERRIDEs) so it will be possible to remove the obsolete callback here.

+    // Request a screen orientation lock and pass a |callback| object to be used
+    // to notify of success/failure. The |callback| parameter is expected to be
+    // owned by the implementation.
+    virtual void lockOrientation(WebScreenOrientationLockType, WebLockOrientationCallback* callback)
+    {
+        delete callback; // prevents memory leak if there is no implementation.
+    }
     virtual void unlockOrientation() { }