Source/modules/screen_orientation/ScreenOrientation.idl - Issue 283423005: Use Promises for screen.lockOrientation().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.idl

Issue 283423005: Use Promises for screen.lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: cdumez comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/screen_orientation/ScreenOrientation.idl

diff --git a/Source/modules/screen_orientation/ScreenOrientation.idl b/Source/modules/screen_orientation/ScreenOrientation.idl

index 310a07b69bcef8ff71409757c0d82d2f4f4942f9..caddb8570eb076641952446b0888dd99415f796b 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.idl

+++ b/Source/modules/screen_orientation/ScreenOrientation.idl

@@ -24,7 +24,7 @@ enum OrientationLockType {

] partial interface Screen {

readonly attribute OrientationType orientation;

- [RaisesException] boolean lockOrientation(OrientationLockType orientation);

+ [CallWith=ExecutionContext] Promise lockOrientation(OrientationLockType orientation);

yhirano 2014/05/22 03:48:43 You can use CallWith=ScriptState

mlamouri (slow - plz ping) 2014/05/22 08:58:56 Done.

void unlockOrientation();

};