Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2834183003:
Disable flaky testBrowsingPostEntryWithKeyboard on devices. (Closed)
|
Created:
3 years, 8 months ago by liaoyuke Modified:
3 years, 8 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable flaky testBrowsingPostEntryWithKeyboard on devices.
testBrowsingPostEntryWithKeyboard is flaky on devices. For example:
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/
iphone10-device-x64/builds/4627
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/
iphone10-device-x64/builds/4622
TBR=eugenebut@chromium.org
BUG=704618
Review-Url: https://codereview.chromium.org/2834183003
Cr-Commit-Position: refs/heads/master@{#466481}
Committed: https://chromium.googlesource.com/chromium/src/+/3a3fc00c8e6a6a50be35443c6d44238fd6258842
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (7 generated)
Description was changed from ========== Disable flaky testBrowsingPostEntryWithKeyboard. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=704618 ========== to ========== Disable flaky testBrowsingPostEntryWithKeyboard on devices. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=704618 ==========
Description was changed from ========== Disable flaky testBrowsingPostEntryWithKeyboard on devices. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=704618 ========== to ========== Disable flaky testBrowsingPostEntryWithKeyboard on devices. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG=704618 ==========
liaoyuke@chromium.org changed reviewers: + eugenebut@chromium.org
liaoyuke@chromium.org changed reviewers: + gchatz@chromium.org
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492814304613530, "parent_rev":
"36728e56fac466656a8504cbcbd573576b9c0bdb", "commit_rev":
"3a3fc00c8e6a6a50be35443c6d44238fd6258842"}
Message was sent while issue was closed.
Description was changed from ========== Disable flaky testBrowsingPostEntryWithKeyboard on devices. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG=704618 ========== to ========== Disable flaky testBrowsingPostEntryWithKeyboard on devices. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG=704618 Review-Url: https://codereview.chromium.org/2834183003 Cr-Commit-Position: refs/heads/master@{#466481} Committed: https://chromium.googlesource.com/chromium/src/+/3a3fc00c8e6a6a50be35443c6d44... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3a3fc00c8e6a6a50be35443c6d44...
Message was sent while issue was closed.
https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... File ios/chrome/browser/web/browsing_egtest.mm (right): https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... ios/chrome/browser/web/browsing_egtest.mm:610: #if !TARGET_IPHONE_SIMULATOR We use MAYBE_ macro for disabling tests on device
Message was sent while issue was closed.
I'm not sure what is the general policy, but it seems that most of our disabled device tests used EARL_GREY_TEST_DISABLED in our code base. On Fri, Apr 21, 2017 at 3:50 PM <eugenebut@chromium.org> wrote: > > > https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... > File ios/chrome/browser/web/browsing_egtest.mm (right): > > > https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... > ios/chrome/browser/web/browsing_egtest.mm:610: #if > !TARGET_IPHONE_SIMULATOR > We use MAYBE_ macro for disabling tests on device > > https://codereview.chromium.org/2834183003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Specifically eg test. On Fri, Apr 21, 2017 at 3:53 PM Yuke Liao <liaoyuke@chromium.org> wrote: > I'm not sure what is the general policy, but it seems that most of our > disabled device tests used EARL_GREY_TEST_DISABLED in our code base. > > On Fri, Apr 21, 2017 at 3:50 PM <eugenebut@chromium.org> wrote: > >> >> >> https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... >> File ios/chrome/browser/web/browsing_egtest.mm (right): >> >> >> https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... >> ios/chrome/browser/web/browsing_egtest.mm:610: #if >> !TARGET_IPHONE_SIMULATOR >> We use MAYBE_ macro for disabling tests on device >> >> https://codereview.chromium.org/2834183003/ >> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Interesting. Maybe (no pun intended) we stopped using MAYBE_ for EG tests. On Fri, Apr 21, 2017 at 3:54 PM, Yuke Liao <liaoyuke@chromium.org> wrote: > Specifically eg test. > > On Fri, Apr 21, 2017 at 3:53 PM Yuke Liao <liaoyuke@chromium.org> wrote: > >> I'm not sure what is the general policy, but it seems that most of our >> disabled device tests used EARL_GREY_TEST_DISABLED in our code base. >> >> On Fri, Apr 21, 2017 at 3:50 PM <eugenebut@chromium.org> wrote: >> >>> >>> https://codereview.chromium.org/2834183003/diff/1/ios/ >>> chrome/browser/web/browsing_egtest.mm >>> File ios/chrome/browser/web/browsing_egtest.mm (right): >>> >>> https://codereview.chromium.org/2834183003/diff/1/ios/ >>> chrome/browser/web/browsing_egtest.mm#newcode610 >>> ios/chrome/browser/web/browsing_egtest.mm:610: #if >>> !TARGET_IPHONE_SIMULATOR >>> We use MAYBE_ macro for disabling tests on device >>> >>> https://codereview.chromium.org/2834183003/ >>> >> -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
I talked to baxley@, he prefers MAYBE_, but he thinks either is OK for eg test. WDYT? On Fri, Apr 21, 2017 at 4:02 PM Eugene But <eugenebut@chromium.org> wrote: > Interesting. Maybe (no pun intended) we stopped using MAYBE_ for EG tests. > > On Fri, Apr 21, 2017 at 3:54 PM, Yuke Liao <liaoyuke@chromium.org> wrote: > >> Specifically eg test. >> >> On Fri, Apr 21, 2017 at 3:53 PM Yuke Liao <liaoyuke@chromium.org> wrote: >> >>> I'm not sure what is the general policy, but it seems that most of our >>> disabled device tests used EARL_GREY_TEST_DISABLED in our code base. >>> >>> On Fri, Apr 21, 2017 at 3:50 PM <eugenebut@chromium.org> wrote: >>> >>>> >>>> >>>> https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... >>>> File ios/chrome/browser/web/browsing_egtest.mm (right): >>>> >>>> >>>> https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... >>>> ios/chrome/browser/web/browsing_egtest.mm:610: #if >>>> !TARGET_IPHONE_SIMULATOR >>>> We use MAYBE_ macro for disabling tests on device >>>> >>>> https://codereview.chromium.org/2834183003/ >>>> >>> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
I think MAYBE_ has some good advantages, but it looks that it's not used anymore. So yeah, I guess either way is fine now. On Fri, Apr 21, 2017 at 4:09 PM, Yuke Liao <liaoyuke@chromium.org> wrote: > I talked to baxley@, he prefers MAYBE_, but he thinks either is OK for eg > test. WDYT? > > On Fri, Apr 21, 2017 at 4:02 PM Eugene But <eugenebut@chromium.org> wrote: > >> Interesting. Maybe (no pun intended) we stopped using MAYBE_ for EG >> tests. >> >> On Fri, Apr 21, 2017 at 3:54 PM, Yuke Liao <liaoyuke@chromium.org> wrote: >> >>> Specifically eg test. >>> >>> On Fri, Apr 21, 2017 at 3:53 PM Yuke Liao <liaoyuke@chromium.org> wrote: >>> >>>> I'm not sure what is the general policy, but it seems that most of our >>>> disabled device tests used EARL_GREY_TEST_DISABLED in our code base. >>>> >>>> On Fri, Apr 21, 2017 at 3:50 PM <eugenebut@chromium.org> wrote: >>>> >>>>> >>>>> https://codereview.chromium.org/2834183003/diff/1/ios/ >>>>> chrome/browser/web/browsing_egtest.mm >>>>> File ios/chrome/browser/web/browsing_egtest.mm (right): >>>>> >>>>> https://codereview.chromium.org/2834183003/diff/1/ios/ >>>>> chrome/browser/web/browsing_egtest.mm#newcode610 >>>>> ios/chrome/browser/web/browsing_egtest.mm:610: #if >>>>> !TARGET_IPHONE_SIMULATOR >>>>> We use MAYBE_ macro for disabling tests on device >>>>> >>>>> https://codereview.chromium.org/2834183003/ >>>>> >>>> >> -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Thank you for confirming! On Fri, Apr 21, 2017 at 4:19 PM Eugene But <eugenebut@chromium.org> wrote: > I think MAYBE_ has some good advantages, but it looks that it's not used > anymore. So yeah, I guess either way is fine now. > > On Fri, Apr 21, 2017 at 4:09 PM, Yuke Liao <liaoyuke@chromium.org> wrote: > >> I talked to baxley@, he prefers MAYBE_, but he thinks either is OK for >> eg test. WDYT? >> >> On Fri, Apr 21, 2017 at 4:02 PM Eugene But <eugenebut@chromium.org> >> wrote: >> >>> Interesting. Maybe (no pun intended) we stopped using MAYBE_ for EG >>> tests. >>> >>> On Fri, Apr 21, 2017 at 3:54 PM, Yuke Liao <liaoyuke@chromium.org> >>> wrote: >>> >>>> Specifically eg test. >>>> >>>> On Fri, Apr 21, 2017 at 3:53 PM Yuke Liao <liaoyuke@chromium.org> >>>> wrote: >>>> >>>>> I'm not sure what is the general policy, but it seems that most of our >>>>> disabled device tests used EARL_GREY_TEST_DISABLED in our code base. >>>>> >>>>> On Fri, Apr 21, 2017 at 3:50 PM <eugenebut@chromium.org> wrote: >>>>> >>>>>> >>>>>> >>>>>> https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... >>>>>> File ios/chrome/browser/web/browsing_egtest.mm (right): >>>>>> >>>>>> >>>>>> https://codereview.chromium.org/2834183003/diff/1/ios/chrome/browser/web/brow... >>>>>> ios/chrome/browser/web/browsing_egtest.mm:610: #if >>>>>> !TARGET_IPHONE_SIMULATOR >>>>>> We use MAYBE_ macro for disabling tests on device >>>>>> >>>>>> https://codereview.chromium.org/2834183003/ >>>>>> >>>>> >>> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
