Add time stamp to the constructor of the events

Add time stamp to the constructor of the events

To match the pointerevent and its corresponding
mouse and touch events time stamps we need to
have the time stamp in the constructor parameter.

Note that having the time stamp in the EventInit
dictionary is being debated as part of this issue:
https://github.com/whatwg/dom/issues/76

BUG=710442
Review-Url: https://codereview.chromium.org/2834183002
Cr-Commit-Position: refs/heads/master@{#466690}
Committed: https://chromium.googlesource.com/chromium/src/+/c9291d203486935075ef689647fb071e99232f2a

[Navid Zolghadr, 2017-04-21 19:18:37]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 19:19:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-04-21 19:38:05]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2017-04-21 20:18:11]

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html
(right):

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html:84:
console.log('navid');
I think the console.log('navid') should be removed.

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html:87:
console.log('i=' + i + ' ' +coalescedEvents[i].timeStamp + ' ' +
coalescedEvents[i-1].timeStamp);
likewise with this log.

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.h:263: TimeTicks platform_time_stamp
= TimeTicks::Now());
We should follow the Google C++ coding guide here because the timestamp doesn't
always return the same value:
https://google.github.io/styleguide/cppguide.html#Default_Arguments

Probably defining this as:

Event(const AtomicString& type,
      const EventInit&,
      TimeTicks platform_time_stamp);

Event(const AtomicString& type,
      const EventInit& init)  : Event(type, init, TimeTicks::Now()) {
}

is likely best.

[commit-bot: I haz the power, 2017-04-21 21:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:10:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2017-04-24 15:19:12]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[Navid Zolghadr, 2017-04-24 15:19:41]

ptal

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html
(right):

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html:84:
console.log('navid');
On 2017/04/21 20:18:10, dtapuska wrote:
> I think the console.log('navid') should be removed.

I somehow have very clear memory of removing these logs before commit. :)
Anyhow, removed.

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.h:263: TimeTicks platform_time_stamp
= TimeTicks::Now());
On 2017/04/21 20:18:10, dtapuska wrote:
> We should follow the Google C++ coding guide here because the timestamp
doesn't
> always return the same value:
> https://google.github.io/styleguide/cppguide.html#Default_Arguments
> 
> Probably defining this as:
> 
> Event(const AtomicString& type,
>       const EventInit&,
>       TimeTicks platform_time_stamp);
> 
> Event(const AtomicString& type,
>       const EventInit& init)  : Event(type, init, TimeTicks::Now()) {
> }
> 
> is likely best.
> 
> 

Done.

[commit-bot: I haz the power, 2017-04-24 15:19:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-04-24 15:27:31]

On 2017/04/24 15:19:41, Navid Zolghadr wrote:
> ptal
> 
>
https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html
> (right):
> 
>
https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html:84:
> console.log('navid');
> On 2017/04/21 20:18:10, dtapuska wrote:
> > I think the console.log('navid') should be removed.
> 
> I somehow have very clear memory of removing these logs before commit. :)
> Anyhow, removed.
> 
>
https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/events/Event.h (right):
> 
>
https://codereview.chromium.org/2834183002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/events/Event.h:263: TimeTicks
platform_time_stamp
> = TimeTicks::Now());
> On 2017/04/21 20:18:10, dtapuska wrote:
> > We should follow the Google C++ coding guide here because the timestamp
> doesn't
> > always return the same value:
> > https://google.github.io/styleguide/cppguide.html#Default_Arguments
> > 
> > Probably defining this as:
> > 
> > Event(const AtomicString& type,
> >       const EventInit&,
> >       TimeTicks platform_time_stamp);
> > 
> > Event(const AtomicString& type,
> >       const EventInit& init)  : Event(type, init, TimeTicks::Now()) {
> > }
> > 
> > is likely best.
> > 
> > 
> 
> Done.

lgtm % typos and nits

[dtapuska, 2017-04-24 15:27:43]

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp (right):

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:176: double
base_time = 123;
Can we use
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebIn...
here?

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:179:
pointer_type, raw_id, modifiers, 123 + i));
Can this be base_time + i (instead of 123 + i) ?

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/PointerEventManager.cpp (right):

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/PointerEventManager.cpp:242: void
PointerEventManager::BlockTouchPointers(TimeTicks platfrom_time_stamp) {
s/platfrom/platform/

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/PointerEventManager.h (right):

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/PointerEventManager.h:135: void
BlockTouchPointers(TimeTicks platfrom_time_stamp);
s/platfrom/platform/

[Navid Zolghadr, 2017-04-24 15:51:15]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[Navid Zolghadr, 2017-04-24 15:51:45]

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp (right):

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:176: double
base_time = 123;
On 2017/04/24 15:27:43, dtapuska wrote:
> Can we use
>
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebIn...
> here?
> 

Makes sense. Done.

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:179:
pointer_type, raw_id, modifiers, 123 + i));
On 2017/04/24 15:27:43, dtapuska wrote:
> Can this be base_time + i (instead of 123 + i) ?

Done.

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/PointerEventManager.cpp (right):

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/PointerEventManager.cpp:242: void
PointerEventManager::BlockTouchPointers(TimeTicks platfrom_time_stamp) {
On 2017/04/24 15:27:43, dtapuska wrote:
> s/platfrom/platform/

Done.

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/PointerEventManager.h (right):

https://codereview.chromium.org/2834183002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/PointerEventManager.h:135: void
BlockTouchPointers(TimeTicks platfrom_time_stamp);
On 2017/04/24 15:27:43, dtapuska wrote:
> s/platfrom/platform/

Done.

[commit-bot: I haz the power, 2017-04-24 15:51:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 17:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 17:58:30]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-04-24 18:11:16]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-04-24 18:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2834183002/#ps40001
(title: "Fix typos")

[commit-bot: I haz the power, 2017-04-24 18:12:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 18:18:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493057476266070,
"parent_rev": "3858a3320d4c95db2662b8e1b6e34c3bda979135", "commit_rev":
"c9291d203486935075ef689647fb071e99232f2a"}

[commit-bot: I haz the power, 2017-04-24 18:19:09]

Description was changed from

==========
Add time stamp to the constructor of the events

To match the pointerevent and its corresponding
mouse and touch events time stamps we need to
have the time stamp in the constructor parameter.

Note that having the time stamp in the EventInit
dictionary is being debated as part of this issue:
https://github.com/whatwg/dom/issues/76

BUG=710442
==========

to

==========
Add time stamp to the constructor of the events

To match the pointerevent and its corresponding
mouse and touch events time stamps we need to
have the time stamp in the constructor parameter.

Note that having the time stamp in the EventInit
dictionary is being debated as part of this issue:
https://github.com/whatwg/dom/issues/76

BUG=710442

Review-Url: https://codereview.chromium.org/2834183002
Cr-Commit-Position: refs/heads/master@{#466690}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9291d203486935075ef689647fb...
==========

[commit-bot: I haz the power, 2017-04-24 18:19:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c9291d203486935075ef689647fb...