Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 2834173002: ui: remove dead NativeThemeMac code (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: remove dead NativeThemeMac code The code for drawing Shiny Modern style buttons is long-dead. BUG=629958 Review-Url: https://codereview.chromium.org/2834173002 Cr-Commit-Position: refs/heads/master@{#466623} Committed: https://chromium.googlesource.com/chromium/src/+/4ae3b7003dfa719948403cfceb9410028ac47835

Patch Set 1 #

Patch Set 2 : remove dead includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -161 lines) Patch
M ui/native_theme/native_theme_mac.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 2 chunks +0 lines, -152 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Elly Fong-Jones
sky: ptal? :)
3 years, 8 months ago (2017-04-21 18:46:10 UTC) #3
sky
LGTM If there any stale includes please remove them.
3 years, 8 months ago (2017-04-21 20:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834173002/20001
3 years, 8 months ago (2017-04-24 13:24:24 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 13:41:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ae3b7003dfa719948403cfceb94...

Powered by Google App Engine
This is Rietveld 408576698