Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2834033003: Update externs for accessibilityPrivate (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, je_julie, jlklein+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update externs for accessibilityPrivate The API was modified here: https://codereview.chromium.org/2808053004 BUG=662501 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2834033003 Cr-Commit-Position: refs/heads/master@{#466453} Committed: https://chromium.googlesource.com/chromium/src/+/248a8e115572e07479edbe71820a90098f12a537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M third_party/closure_compiler/externs/accessibility_private.js View 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dmazzoni
3 years, 8 months ago (2017-04-21 16:04:23 UTC) #3
Dan Beam
lgtm
3 years, 8 months ago (2017-04-21 17:34:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834033003/1
3 years, 8 months ago (2017-04-21 21:35:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 21:40:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/248a8e115572e07479edbe71820a...

Powered by Google App Engine
This is Rietveld 408576698