Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: content/common/navigation_params_unittest.cc

Issue 2834013002: PlzNavigate: make MHTML iframe load working. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params_unittest.cc
diff --git a/content/common/navigation_params_unittest.cc b/content/common/navigation_params_unittest.cc
index ee1f96a68e0f890529f18b60a8a4e1254bffa109..0fdadef61ea4d4aa06ed0dd344a13827ee4ef9cf 100644
--- a/content/common/navigation_params_unittest.cc
+++ b/content/common/navigation_params_unittest.cc
@@ -17,11 +17,11 @@ TEST(NavigationParamsTest, ShouldMakeNetworkRequestForURL) {
EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("http://foo/bar.html")));
EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("https://foo/bar.html")));
EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("data://foo")));
+ EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("cid:foo@bar")));
carlosk 2017/05/03 16:56:49 nit: Please add a comment explaining why cid: and
arthursonzogni 2017/05/04 14:26:32 Yes, really good idea, especially for "data:". Don
EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("about:blank")));
EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("about:srcdoc")));
EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("javascript://foo.js")));
- EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("cid:foo@bar")));
EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL()));
}

Powered by Google App Engine
This is Rietveld 408576698