PlzNavigate: make MHTML iframe load working.

content/common/navigation_params_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace content {
 
 TEST(NavigationParamsTest, ShouldMakeNetworkRequestForURL) {
   if (!IsBrowserSideNavigationEnabled())
     return;
 
   EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("http://foo/bar.html")));
   EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("https://foo/bar.html")));
   EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("data://foo")));
+  EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("cid:foo@bar")));

[carlosk, 2017/05/03 16:56:49]

nit: Please add a comment explaining why cid: and data: URLs should return
|true| here even though they don't actually generate actual network requests.
It could be something in the lines of: "Even though data: and cid: schemes do
not generate actual network requests they must be handled by the network stack
and so must return true for this check."

[arthursonzogni, 2017/05/04 14:26:32]

Yes, really good idea, especially for "data:".
Done.

 
   EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("about:blank")));
   EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("about:srcdoc")));
   EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("javascript://foo.js")));
-  EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("cid:foo@bar")));
   EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL()));
 }
 
 }  // namespace content