Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2948)

Unified Diff: chrome/browser/notifications/notification_interactive_uitest_support.cc

Issue 2833993002: Enable MacOSX native notifications by default (Closed)
Patch Set: Test fixes (with great help of peter@) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_interactive_uitest_support.cc
diff --git a/chrome/browser/notifications/notification_interactive_uitest_support.cc b/chrome/browser/notifications/notification_interactive_uitest_support.cc
index 73680f9a35c053d7182f219bc01404b4395145c4..aac57fe28f59fad5c977bfdd68102a012e2c590f 100644
--- a/chrome/browser/notifications/notification_interactive_uitest_support.cc
+++ b/chrome/browser/notifications/notification_interactive_uitest_support.cc
@@ -116,6 +116,16 @@ bool MessageCenterChangeObserver::Wait() {
// -----------------------------------------------------------------------------
+void NotificationsTest::SetUpDefaultCommandLine(
Peter Beverloo 2017/04/24 16:11:16 I think it's more common to override SetUpCommandL
Miguel Garcia 2017/04/24 17:26:04 Acknowledged.
+ base::CommandLine* command_line) {
+ InProcessBrowserTest::SetUpDefaultCommandLine(command_line);
+// Temporary change while the whole support class is changed to deal
+// with native notifications.
Peter Beverloo 2017/04/24 16:11:16 nit: refer to a bug
Miguel Garcia 2017/04/24 17:26:04 Done.
+#if defined(OS_MACOSX)
+ command_line->AppendSwitchASCII("disable-features", "NativeNotifications");
Peter Beverloo 2017/04/24 16:11:16 #include "chrome/common/chrome_features.h" #includ
Miguel Garcia 2017/04/24 17:26:04 Done.
+#endif
+}
+
int NotificationsTest::GetNotificationCount() {
return message_center::MessageCenter::Get()->NotificationCount();
}

Powered by Google App Engine
This is Rietveld 408576698