Enable MacOSX native notifications by default

chrome/browser/notifications/notification_interactive_uitest_support.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_interactive_uitest_support.h"
 
 #include "base/run_loop.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
@@ skipping 98 matching lines @@
 
 MessageCenterChangeObserver::MessageCenterChangeObserver() : impl_(new Impl) {}
 MessageCenterChangeObserver::~MessageCenterChangeObserver() = default;
 
 bool MessageCenterChangeObserver::Wait() {
   return impl_->Wait();
 }
 
 // -----------------------------------------------------------------------------
 
+void NotificationsTest::SetUpDefaultCommandLine(

[Peter Beverloo, 2017/04/24 16:11:16]

I think it's more common to override SetUpCommandLine()

[Miguel Garcia, 2017/04/24 17:26:04]

Acknowledged.

+    base::CommandLine* command_line) {
+  InProcessBrowserTest::SetUpDefaultCommandLine(command_line);
+// Temporary change while the whole support class is changed to deal
+// with native notifications.

[Peter Beverloo, 2017/04/24 16:11:16]

nit: refer to a bug

[Miguel Garcia, 2017/04/24 17:26:04]

Done.

+#if defined(OS_MACOSX)
+  command_line->AppendSwitchASCII("disable-features", "NativeNotifications");

[Peter Beverloo, 2017/04/24 16:11:16]

#include "chrome/common/chrome_features.h"
#include "content/public/common/content_switches.h"

"disable-features" -> content::kDisableFeatures
"NativeNotifications" -> features::kNativeNotifications.name

[Miguel Garcia, 2017/04/24 17:26:04]

Done.

+#endif
+}
+
 int NotificationsTest::GetNotificationCount() {
   return message_center::MessageCenter::Get()->NotificationCount();
 }
 
 int NotificationsTest::GetNotificationPopupCount() {
   return message_center::MessageCenter::Get()->GetPopupNotifications().size();
 }
 
 void NotificationsTest::CloseBrowserWindow(Browser* browser) {
   content::WindowedNotificationObserver observer(
@@ skipping 161 matching lines @@
 
 void NotificationsTest::DisableFullscreenNotifications() {
   feature_list_.InitWithFeatures(
       {features::kPreferHtmlOverPlugins},
       {features::kAllowFullscreenWebNotificationsFeature});
 }
 
 void NotificationsTest::DropOriginPreference(const GURL& origin) {
   DesktopNotificationProfileUtil::ClearSetting(browser()->profile(), origin);
 }