Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2833983005: M59 Merge of 'Improve canonicalization of mailto url path components' (Closed)

Created:
3 years, 8 months ago by elawrence
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

M59 Merge of 'Improve canonicalization of mailto url path components' The canonicalization of the path component of mailto urls is too lax, leading to information disclosure and possible command injection attacks against mail clients. To fix this, we percent-encode more characters in the path component of mailto urls, matching other Firefox/IE/Edge. The original land of this patch (via 2817213002) omitted an update to layout tests. BUG=711020 TEST=url_unittests,run-webkit-tests fast/url Review-Url: https://codereview.chromium.org/2820373002 Cr-Commit-Position: refs/heads/master@{#465357} (cherry picked from commit d75485096f20f4ba7365106c46200b18c0fcc848) Review-Url: https://codereview.chromium.org/2833983005 . Cr-Commit-Position: refs/branch-heads/3071@{#128} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/18bf33f85e323bf4bf93f3db3c42e542dd9cb9f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/fast/url/mailto-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/url/script-tests/mailto.js View 1 chunk +2 lines, -1 line 0 comments Download
M url/url_canon_mailtourl.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M url/url_canon_unittest.cc View 2 chunks +45 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
elawrence
3 years, 8 months ago (2017-04-21 20:01:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18bf33f85e323bf4bf93f3db3c42e542dd9cb9f2.

Powered by Google App Engine
This is Rietveld 408576698