Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2833983004: bindings: Port away from ToImplArray/ToMemberNativeArray. (Closed)

Created:
3 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 8 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Port away from ToImplArray/ToMemberNativeArray. Now that the bindings themselves have been converted, move callers in core/ and modules/ to NativeValueTraits::NativeValue(), which implements the current WebIDL JS->sequence conversion steps that the To*Array() functions do not. BUG=690428 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2833983004 Cr-Commit-Position: refs/heads/master@{#466624} Committed: https://chromium.googlesource.com/chromium/src/+/6a454cf34b139d4b7768e0fcc7fbb035506e14c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/csspaint/parse-input-arguments-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/registerPaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Raphael Kubo da Costa (rakuco)
PTAL
3 years, 8 months ago (2017-04-21 15:44:24 UTC) #1
haraken
LGTM
3 years, 8 months ago (2017-04-21 15:45:35 UTC) #4
bashi
lgtm
3 years, 8 months ago (2017-04-24 00:45:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833983004/1
3 years, 8 months ago (2017-04-24 09:13:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437269)
3 years, 8 months ago (2017-04-24 11:45:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833983004/1
3 years, 8 months ago (2017-04-24 12:31:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6a454cf34b139d4b7768e0fcc7fbb035506e14c3
3 years, 8 months ago (2017-04-24 13:45:07 UTC) #16
Yuki
3 years, 8 months ago (2017-04-25 08:21:49 UTC) #17
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698