Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2833983002: Test network annotation tags added to unittests in net/. (Closed)

Created:
3 years, 8 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
Reviewers:
asanka
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, net-reviews_chromium.org, bnc+watch_chromium.org, tbansal+watch-nqe_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Test network annotation tags added to unittests in net/. Test network annotation tags added to network requests of: net/base/layered_network_delegate_unittest.cc net/filter/sdch_policy_delegate_unittest.cc net/log/net_log_util_unittest.cc net/log/write_to_file_net_log_observer_unittest.cc net/nqe/network_quality_estimator_test_util.cc net/nqe/network_quality_estimator_unittest.cc net/nqe/throughput_analyzer_unittest.cc net/quic/chromium/quic_network_transaction_unittest.cc net/spdy/spdy_network_transaction_unittest.cc net/test/embedded_test_server/embedded_test_server_unittest.cc net/websockets/websocket_end_to_end_test.cc BUG=656607 Review-Url: https://codereview.chromium.org/2833983002 Cr-Commit-Position: refs/heads/master@{#467601} Committed: https://chromium.googlesource.com/chromium/src/+/9ebaba7e8e9888ff16ee524ca4fb18db77224fd1

Patch Set 1 #

Patch Set 2 : One file moved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -73 lines) Patch
M net/base/layered_network_delegate_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/filter/sdch_policy_delegate_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/log/net_log_util_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/log/write_to_file_net_log_observer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/nqe/network_quality_estimator_test_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 22 chunks +67 lines, -44 lines 0 comments Download
M net/nqe/throughput_analyzer_unittest.cc View 4 chunks +12 lines, -7 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M net/spdy/chromium/spdy_network_transaction_unittest.cc View 1 6 chunks +9 lines, -5 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Ramin Halavati
I have added TEST_NETWORK_ANNOTATION_TAGS to some unittests in net. Please review.
3 years, 8 months ago (2017-04-21 07:48:20 UTC) #7
asanka
lgtm
3 years, 8 months ago (2017-04-26 20:16:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833983002/1
3 years, 7 months ago (2017-04-27 04:39:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/256352) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-04-27 04:42:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833983002/20001
3 years, 7 months ago (2017-04-27 05:08:10 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 06:16:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ebaba7e8e9888ff16ee524ca4fb...

Powered by Google App Engine
This is Rietveld 408576698