android_webview/browser/aw_safe_browsing_ui_manager.h - Issue 2833923002: WebView: carefully check size for SafeBrowsing interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_safe_browsing_ui_manager.h

Issue 2833923002: WebView: carefully check size for SafeBrowsing interstitial (Closed)

Patch Set: Also check if attached, add @VisibleForTesting Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_safe_browsing_ui_manager.h

diff --git a/android_webview/browser/aw_safe_browsing_ui_manager.h b/android_webview/browser/aw_safe_browsing_ui_manager.h

index f09bdf687513f4ed0090d03aafdf4334163a33ca..2dd07b837f55a224d69e61dcffb08678cf03e401 100644

--- a/android_webview/browser/aw_safe_browsing_ui_manager.h

+++ b/android_webview/browser/aw_safe_browsing_ui_manager.h

@@ -21,7 +21,7 @@ class AwSafeBrowsingUIManager : public safe_browsing::BaseUIManager {

static UIManagerClient* FromWebContents(content::WebContents* web_contents);

// Whether this web contents can show an interstitial

- virtual bool CanShowInterstitial() = 0;

+ virtual bool CanShowBigInterstitial() = 0;

};

// Construction needs to happen on the UI thread.

« no previous file with comments | « no previous file | android_webview/browser/aw_safe_browsing_ui_manager.cc » ('j') | no next file with comments »