android_webview/browser/aw_safe_browsing_ui_manager.cc - Issue 2833923002: WebView: carefully check size for SafeBrowsing interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_safe_browsing_ui_manager.cc

Issue 2833923002: WebView: carefully check size for SafeBrowsing interstitial (Closed)

Patch Set: Also check if attached, add @VisibleForTesting Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_safe_browsing_ui_manager.cc

diff --git a/android_webview/browser/aw_safe_browsing_ui_manager.cc b/android_webview/browser/aw_safe_browsing_ui_manager.cc

index c2ac6571f7e39b52f60b7082abb4ba8fb586e3b5..fdcc6d30d9564fae00d2340a1597c92cc61fe70c 100644

--- a/android_webview/browser/aw_safe_browsing_ui_manager.cc

+++ b/android_webview/browser/aw_safe_browsing_ui_manager.cc

@@ -24,7 +24,7 @@ void AwSafeBrowsingUIManager::DisplayBlockingPage(

WebContents* web_contents = resource.web_contents_getter.Run();

// Check the size of the view

UIManagerClient* client = UIManagerClient::FromWebContents(web_contents);

- if (!client || !client->CanShowInterstitial()) {

+ if (!client || !client->CanShowBigInterstitial()) {

LOG(WARNING) << "The view is not suitable to show the SB interstitial";

OnBlockingPageDone(std::vector<UnsafeResource>{resource}, false,

web_contents, resource.url.GetWithEmptyPath());