[Android WebView] Trigger minidump uploading on renderer crash.

android_webview/browser/aw_browser_terminator.cc

Index: android_webview/browser/aw_browser_terminator.cc
diff --git a/android_webview/browser/aw_browser_terminator.cc b/android_webview/browser/aw_browser_terminator.cc
index 0088138c6d6003790afed9bea599f066b4e20ff0..faf50d954de64734d85d4e6847782e206656b045 100644
--- a/android_webview/browser/aw_browser_terminator.cc
+++ b/android_webview/browser/aw_browser_terminator.cc
@@ -6,6 +6,7 @@
 
 #include <unistd.h>
 
+#include "android_webview/browser/aw_browser_process.h"
 #include "android_webview/browser/aw_render_process_gone_delegate.h"
 #include "android_webview/common/aw_descriptors.h"
 #include "android_webview/common/crash_reporter/aw_microdump_crash_reporter.h"
@@ -85,6 +86,7 @@ void OnRenderProcessGoneDetail(int child_process_id,
       }
     }
   }
+  TriggerMinidumpUploading();

[gsennton, 2017/04/20 20:37:06]

Oooh, another question for Toby: is the minidump for the render process
generated at this point, or could we have a race here where the minidump hasn't
been generated when we try to copy it from AwBrowserProcess?

[Tobias Sargeant, 2017/04/21 16:18:04]

breakpad::CrashDumpManager is registered prior to AwBrowserTerminator so that
this can be guaranteed. It's a little bit hairy because OnChildExit is called in
order for the two objects on the UI thread, and both post to the FILE thread,
and AwBrowserTerminator then posts back to the UI thread. But the net result is
that this will come after the minidump has been moved to the crash directory.

[gsennton, 2017/04/24 12:39:54]

Thanks, I added a comment about this :) (please let me know if the comment isn't
verbose enough).

 }
 
 }  // namespace