[Android WebView] Trigger minidump uploading on renderer crash.

android_webview/browser/aw_browser_terminator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_browser_terminator.h"
 
 #include <unistd.h>
 
+#include "android_webview/browser/aw_browser_process.h"
 #include "android_webview/browser/aw_render_process_gone_delegate.h"
 #include "android_webview/common/aw_descriptors.h"
 #include "android_webview/common/crash_reporter/aw_microdump_crash_reporter.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/sync_socket.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 59 matching lines @@
         // The render process was most likely killed for OOM or switching
         // WebView provider, to make WebView backward compatible, kills the
         // browser process instead of triggering crash.
         LOG(ERROR) << "Render process (" << child_process_pid << ") kill (OOM"
                    << " or update) wasn't handed by all associated webviews,"
                    << " killing application.";
         kill(getpid(), SIGKILL);
       }
     }
   }
+  TriggerMinidumpUploading();

[gsennton, 2017/04/20 20:37:06]

Oooh, another question for Toby: is the minidump for the render process
generated at this point, or could we have a race here where the minidump hasn't
been generated when we try to copy it from AwBrowserProcess?

[Tobias Sargeant, 2017/04/21 16:18:04]

breakpad::CrashDumpManager is registered prior to AwBrowserTerminator so that
this can be guaranteed. It's a little bit hairy because OnChildExit is called in
order for the two objects on the UI thread, and both post to the FILE thread,
and AwBrowserTerminator then posts back to the UI thread. But the net result is
that this will come after the minidump has been moved to the crash directory.

[gsennton, 2017/04/24 12:39:54]

Thanks, I added a comment about this :) (please let me know if the comment isn't
verbose enough).

 }
 
 }  // namespace
 
 AwBrowserTerminator::AwBrowserTerminator() {}
 
 AwBrowserTerminator::~AwBrowserTerminator() {}
 
 void AwBrowserTerminator::OnChildStart(int child_process_id,
                                        content::FileDescriptorInfo* mappings) {
@@ skipping 56 matching lines @@
     return;
   OnRenderProcessGone(child_process_id);
   DCHECK(pipe->handle() != base::SyncSocket::kInvalidHandle);
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&AwBrowserTerminator::ProcessTerminationStatus,
                  child_process_id, pid, base::Passed(std::move(pipe))));
 }
 
 }  // namespace breakpad