Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2833853002: Convert constructor/oscillator.html to use new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert constructor/oscillator.html to use new Audit Manually converted to use new Audit. BUG=704967 TEST=constructor/oscillator.html Review-Url: https://codereview.chromium.org/2833853002 Cr-Commit-Position: refs/heads/master@{#467341} Committed: https://chromium.googlesource.com/chromium/src/+/aa935d4a5d6e57bd07fd6eb9eb6e5f6b927110ba

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix test issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -118 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html View 1 2 3 2 chunks +67 lines, -118 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-25 15:10:17 UTC) #2
hongchan
lgtm
3 years, 8 months ago (2017-04-25 20:40:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833853002/40001
3 years, 8 months ago (2017-04-25 21:03:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/438419)
3 years, 8 months ago (2017-04-25 22:22:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833853002/60001
3 years, 8 months ago (2017-04-26 14:55:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 16:24:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aa935d4a5d6e57bd07fd6eb9eb6e...

Powered by Google App Engine
This is Rietveld 408576698