Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2833843004: Reland: Communicate ExtensionSettings policy to renderers (Closed)

Created:
3 years, 8 months ago by nrpeter
Modified:
3 years, 8 months ago
Reviewers:
*Devlin, dcheng, *estark
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Communicate ExtensionSettings policy to renderers Origional CL (2499493004) was rolled back by sheriff due to failing MSAN tests. This initial patchset is a direct patch of 2499493004. Second patchset contains the fix. -Communicate which hosts are runtime blocked to all renderers -Blocks host permissions for specific hosts by specific extensions -Tests via blocking content script injection -Introduces new test class for use with ExtensionSettings policy BUG=624649 Review-Url: https://codereview.chromium.org/2833843004 Cr-Commit-Position: refs/heads/master@{#466832} Committed: https://chromium.googlesource.com/chromium/src/+/e33d2a5b01ecfcb5695bce2e1fa92d13c9b4265a

Patch Set 1 : CL patched with 2499493004 that was rolled back #

Patch Set 2 : Removed unused URLPatternSet parameters in ExtensionMsg_PermissionSetStruct which was causing MSAN … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+998 lines, -100 lines) Patch
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 2 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management.h View 1 chunk +20 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_internal.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_with_management_policy_apitest.h View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_with_management_policy_apitest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.h View 4 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 4 chunks +79 lines, -9 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 3 chunks +107 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data_unittest.cc View 12 chunks +197 lines, -26 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/policy/background.js View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/policy/manifest.json View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/renderer_startup_helper.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M extensions/common/constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/extension.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/extension_messages.h View 1 3 chunks +21 lines, -0 lines 0 comments Download
M extensions/common/extension_messages.cc View 1 4 chunks +21 lines, -3 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 5 chunks +81 lines, -0 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 7 chunks +89 lines, -4 lines 0 comments Download
M extensions/common/url_pattern.h View 4 chunks +24 lines, -1 line 0 comments Download
M extensions/common/url_pattern.cc View 7 chunks +39 lines, -2 lines 0 comments Download
M extensions/common/url_pattern_unittest.cc View 17 chunks +81 lines, -33 lines 0 comments Download
M extensions/renderer/dispatcher.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 5 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
nrpeter
3 years, 8 months ago (2017-04-24 16:09:16 UTC) #8
Devlin
lgtm on the delta between PS 1 & 2.
3 years, 8 months ago (2017-04-24 21:47:52 UTC) #9
estark
ipc diff between ps 1 and 2 lgtm
3 years, 8 months ago (2017-04-24 22:53:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833843004/20001
3 years, 8 months ago (2017-04-25 00:06:13 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 00:13:54 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e33d2a5b01ecfcb5695bce2e1fa9...

Powered by Google App Engine
This is Rietveld 408576698