Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2833843002: Skip the failing slop suppression test in TestExpectations (Closed)

Created:
3 years, 8 months ago by Navid Zolghadr
Modified:
3 years, 8 months ago
Reviewers:
tdanderson, dtapuska
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip the failing slop suppression test in TestExpectations It seems that the original change crrev.com/2816613003 has caused this test to fail. As that change itself is temporary we just skip this test for now. BUG=713740 Review-Url: https://codereview.chromium.org/2833843002 Cr-Commit-Position: refs/heads/master@{#466106} Committed: https://chromium.googlesource.com/chromium/src/+/93dc8900a21b04a878eaaa3ea46a9456d9b1e305

Patch Set 1 #

Patch Set 2 : Skip the test on all the platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Navid Zolghadr
3 years, 8 months ago (2017-04-20 18:00:06 UTC) #4
Navid Zolghadr
3 years, 8 months ago (2017-04-20 18:13:16 UTC) #6
dtapuska
On 2017/04/20 18:13:16, Navid Zolghadr wrote: I wonder if you should mark it failing on ...
3 years, 8 months ago (2017-04-20 18:22:12 UTC) #7
Navid Zolghadr
On 2017/04/20 18:22:12, dtapuska wrote: > On 2017/04/20 18:13:16, Navid Zolghadr wrote: > > I ...
3 years, 8 months ago (2017-04-20 18:24:06 UTC) #8
Navid Zolghadr
ptal
3 years, 8 months ago (2017-04-20 18:31:12 UTC) #11
dtapuska
On 2017/04/20 18:31:12, Navid Zolghadr wrote: > ptal lgtm
3 years, 8 months ago (2017-04-20 18:50:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833843002/20001
3 years, 8 months ago (2017-04-20 18:55:06 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:23:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93dc8900a21b04a878eaaa3ea46a...

Powered by Google App Engine
This is Rietveld 408576698