Initial sets of fixes for themes to work well with HiDPI Windows. More changes coming in a separate…

Initial sets of fixes for themes to work well with HiDPI Windows. More changes coming in a separate CL.

oshima, Please review everything.
sky : For owners review.

1. Removed the PlatformScaleImage function from the ResourceBundle class and the corresponding
   code to scale images. With automatic scaling support in ImageSkia this is no longer needed.

2. The other change is in the NewTabButton class to use floating point scales everywhere instead
   of converting from scale factor to scale using different functions which causes problems.

BUG=362979
R=oshima,sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271075

[oshima, 2014-05-15 23:55:06]

lgtm with one request

https://codereview.chromium.org/283383005/diff/20001/ui/base/resource/resourc...
File ui/base/resource/resource_bundle.cc (left):

https://codereview.chromium.org/283383005/diff/20001/ui/base/resource/resourc...
ui/base/resource/resource_bundle.cc:113: scale_factor = ui::SCALE_FACTOR_100P;
would you mind changing this to

if (scale_factor == ui::SCALE_FACTOR_NONE)
  return gfx::ImageSkiaRep(image, 0.0f);

and remove unscaled variable?

[ananta, 2014-05-16 00:13:48]

https://codereview.chromium.org/283383005/diff/20001/ui/base/resource/resourc...
File ui/base/resource/resource_bundle.cc (left):

https://codereview.chromium.org/283383005/diff/20001/ui/base/resource/resourc...
ui/base/resource/resource_bundle.cc:113: scale_factor = ui::SCALE_FACTOR_100P;
On 2014/05/15 23:55:06, oshima wrote:
> would you mind changing this to
> 
> if (scale_factor == ui::SCALE_FACTOR_NONE)
>   return gfx::ImageSkiaRep(image, 0.0f);
> 
> and remove unscaled variable?

Done.

[oshima, 2014-05-16 00:36:23]

slgtm

thanks

[sky, 2014-05-16 15:51:03]

LGTM

[ananta, 2014-05-16 17:35:21]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-05-16 17:35:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/283383005/40001

[commit-bot: I haz the power, 2014-05-16 19:15:27]

Change committed as 271075