Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2833773004: [Instrumentation Test Speed] Add trace event to the setup logic (Closed)

Created:
3 years, 8 months ago by shenghuazhang
Modified:
3 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Instrumentation Test Speed] Add trace event to the setup logic BUG= Review-Url: https://codereview.chromium.org/2833773004 Cr-Commit-Position: refs/heads/master@{#466463} Committed: https://chromium.googlesource.com/chromium/src/+/0db41d57152ce8627b01a5a221424d5787ab236a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 5 chunks +17 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (4 generated)
shenghuazhang
https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py File build/android/pylib/local/device/local_device_instrumentation_test_run.py (right): https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py#newcode82 build/android/pylib/local/device/local_device_instrumentation_test_run.py:82: def install_helper_internal(apk_path=apk.path): Add the internal function with apk.path argument ...
3 years, 8 months ago (2017-04-21 19:17:22 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py File build/android/pylib/local/device/local_device_instrumentation_test_run.py (right): https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py#newcode82 build/android/pylib/local/device/local_device_instrumentation_test_run.py:82: def install_helper_internal(apk_path=apk.path): On 2017/04/21 19:17:22, shenghuazhang wrote: > ...
3 years, 8 months ago (2017-04-21 20:41:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833773004/1
3 years, 8 months ago (2017-04-21 21:03:12 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 22:13:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0db41d57152ce8627b01a5a22142...

Powered by Google App Engine
This is Rietveld 408576698