[Instrumentation Test Speed] Add trace event to the setup logic

[Instrumentation Test Speed] Add trace event to the setup logic

BUG=

Review-Url: https://codereview.chromium.org/2833773004
Cr-Commit-Position: refs/heads/master@{#466463}
Committed: https://chromium.googlesource.com/chromium/src/+/0db41d57152ce8627b01a5a221424d5787ab236a

[shenghuazhang, 2017-04-21 19:17:21]

shenghuazhang@chromium.org changed reviewers:
+ jbudorick@chromium.org

[shenghuazhang, 2017-04-21 19:17:22]

https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:82:
def install_helper_internal(apk_path=apk.path):
Add the internal function with apk.path argument so that the install process for
each apk can be traced. 
The trace output example:
https://drive.google.com/a/google.com/file/d/0BwXSjqIEYMIkV09DOFBBVE4zbGM/vie...

Could use contextlib_ext in the internal function as well, like:
  def install_helper_internal():
    with contextlib_ext.Optional(
            trace_event.trace(apk.path),
            self._env.trace_output):
      dev.Install(apk, permissions=permissions)

But I think the @trace_event way is much clear.

[jbudorick, 2017-04-21 20:41:08]

lgtm

https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2833773004/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:82:
def install_helper_internal(apk_path=apk.path):
On 2017/04/21 19:17:22, shenghuazhang wrote:
> Add the internal function with apk.path argument so that the install process
for
> each apk can be traced. 
> The trace output example:
>
https://drive.google.com/a/google.com/file/d/0BwXSjqIEYMIkV09DOFBBVE4zbGM/vie...

Why am I not surprised that ChromePublic.apk takes an eternity to install...

> 
> Could use contextlib_ext in the internal function as well, like:
>   def install_helper_internal():
>     with contextlib_ext.Optional(
>             trace_event.trace(apk.path),
>             self._env.trace_output):
>       dev.Install(apk, permissions=permissions)
> 
> But I think the @trace_event way is much clear.

Agreed.

[shenghuazhang, 2017-04-21 21:02:44]

The CQ bit was checked by shenghuazhang@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:03:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 22:13:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492808564928690, "parent_rev":
"5903b9808c095d7c128f32409ee3d3e3c39937c6", "commit_rev":
"0db41d57152ce8627b01a5a221424d5787ab236a"}

[commit-bot: I haz the power, 2017-04-21 22:13:13]

Description was changed from

==========
[Instrumentation Test Speed] Add trace event to the setup logic

BUG=
==========

to

==========
[Instrumentation Test Speed] Add trace event to the setup logic

BUG=

Review-Url: https://codereview.chromium.org/2833773004
Cr-Commit-Position: refs/heads/master@{#466463}
Committed:
https://chromium.googlesource.com/chromium/src/+/0db41d57152ce8627b01a5a22142...
==========

[commit-bot: I haz the power, 2017-04-21 22:13:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0db41d57152ce8627b01a5a22142...