Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2833773002: [modules] Add a simple micro-benchmark for import/export accesses. (Closed)

Created:
3 years, 8 months ago by neis
Modified:
3 years, 8 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Add a simple micro-benchmark for import/export accesses. R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2833773002 Cr-Commit-Position: refs/heads/master@{#44811} Committed: https://chromium.googlesource.com/v8/v8/+/6c0e81bd48a1db3183e0f94c04cb89708da2c61e

Patch Set 1 #

Patch Set 2 : Rename files. #

Patch Set 3 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -0 lines) Patch
M test/js-perf-test/JSTests.json View 1 1 chunk +16 lines, -0 lines 0 comments Download
A test/js-perf-test/Modules/basic-export.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A test/js-perf-test/Modules/basic-import.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
A test/js-perf-test/Modules/basic-namespace.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
A test/js-perf-test/Modules/run.js View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
A test/js-perf-test/Modules/value.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
neis
3 years, 8 months ago (2017-04-20 10:55:13 UTC) #1
adamk
Contents lgtm, but can you give these better names? Maybe: basic1 => export basic2 => ...
3 years, 8 months ago (2017-04-20 19:48:28 UTC) #2
neis
On 2017/04/20 19:48:28, adamk wrote: > Contents lgtm, but can you give these better names? ...
3 years, 8 months ago (2017-04-23 11:04:23 UTC) #3
adamk
lgtm
3 years, 8 months ago (2017-04-24 18:30:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833773002/40001
3 years, 8 months ago (2017-04-24 18:30:10 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:52:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/6c0e81bd48a1db3183e0f94c04cb89708da...

Powered by Google App Engine
This is Rietveld 408576698