Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2833723004: Check the existence of SWContext in DidUpdateNavigationPreloadEnabled/Hexistence (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 8 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the existence of SWContext in DidUpdateNavigationPreloadEnabled/Header. BUG=714043 Review-Url: https://codereview.chromium.org/2833723004 Cr-Commit-Position: refs/heads/master@{#466305} Committed: https://chromium.googlesource.com/chromium/src/+/27d529dd566202cbb4d347d5ccf5d5e0aa198a63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
horo
nhiroki@ Please review this.
3 years, 8 months ago (2017-04-21 07:44:53 UTC) #3
nhiroki
lgtm
3 years, 8 months ago (2017-04-21 08:38:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833723004/1
3 years, 8 months ago (2017-04-21 09:05:05 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 10:38:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27d529dd566202cbb4d347d5ccf5...

Powered by Google App Engine
This is Rietveld 408576698