Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
SharedWorkerRepositoryClientImpl implements classes defined in public/web/
(WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being
moved to core/exported.
SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily
enough didn't use it so we could just break this dependency.
BUG=708879
Review-Url: https://codereview.chromium.org/2833693002
Cr-Commit-Position: refs/heads/master@{#468274}
Committed: https://chromium.googlesource.com/chromium/src/+/2ebe3671d78db19aa97d2c4950069c1ff837c4a5
Description was changed from ========== WebLocalFrameImpl was not being used. git cl format Move SharedWorkerRepositoryClientImpl ...
3 years, 8 months ago
(2017-04-20 04:45:45 UTC)
#1
Description was changed from
==========
WebLocalFrameImpl was not being used.
git cl format
Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
BUG=
==========
to
==========
WebLocalFrameImpl was not being used.
git cl format
Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
BUG=708879
==========
slangley
Description was changed from ========== WebLocalFrameImpl was not being used. git cl format Move SharedWorkerRepositoryClientImpl ...
3 years, 8 months ago
(2017-04-20 04:49:39 UTC)
#2
Description was changed from
==========
WebLocalFrameImpl was not being used.
git cl format
Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
BUG=708879
==========
to
==========
Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
SharedWorkerRepositoryClientImpl implements classes defined in public/web/
(WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being
moved to core/exported.
SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily
enough didn't use it so we could just break this dependency.
BUG=708879
==========
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/255419) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago
(2017-04-26 06:18:33 UTC)
#12
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/355123)
3 years, 8 months ago
(2017-04-26 07:29:06 UTC)
#17
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/398322)
3 years, 8 months ago
(2017-04-27 01:34:57 UTC)
#22
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/217485)
3 years, 7 months ago
(2017-04-28 07:36:50 UTC)
#27
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493602185313140, "parent_rev": "7f022a2ccb293c5b31446f3f5af8be79f46555ba", "commit_rev": "2ebe3671d78db19aa97d2c4950069c1ff837c4a5"}
3 years, 7 months ago
(2017-05-01 03:20:19 UTC)
#31
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493602185313140,
"parent_rev": "7f022a2ccb293c5b31446f3f5af8be79f46555ba", "commit_rev":
"2ebe3671d78db19aa97d2c4950069c1ff837c4a5"}
commit-bot: I haz the power
Description was changed from ========== Move SharedWorkerRepositoryClientImpl from web/ to core/exported/. SharedWorkerRepositoryClientImpl implements classes defined ...
3 years, 7 months ago
(2017-05-01 03:21:03 UTC)
#32
Message was sent while issue was closed.
Description was changed from
==========
Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
SharedWorkerRepositoryClientImpl implements classes defined in public/web/
(WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being
moved to core/exported.
SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily
enough didn't use it so we could just break this dependency.
BUG=708879
==========
to
==========
Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
SharedWorkerRepositoryClientImpl implements classes defined in public/web/
(WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being
moved to core/exported.
SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily
enough didn't use it so we could just break this dependency.
BUG=708879
Review-Url: https://codereview.chromium.org/2833693002
Cr-Commit-Position: refs/heads/master@{#468274}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ebe3671d78db19aa97d2c495006...
==========
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/2ebe3671d78db19aa97d2c4950069c1ff837c4a5
3 years, 7 months ago
(2017-05-01 03:21:07 UTC)
#33
Issue 2833693002: Move SharedWorkerRepositoryClientImpl from web/ to core/exported/.
(Closed)
Created 3 years, 8 months ago by slangley
Modified 3 years, 7 months ago
Reviewers: joelhockey, haraken
Base URL:
Comments: 1