Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2833693002: Move SharedWorkerRepositoryClientImpl from web/ to core/exported/. (Closed)

Created:
3 years, 8 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SharedWorkerRepositoryClientImpl from web/ to core/exported/. SharedWorkerRepositoryClientImpl implements classes defined in public/web/ (WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being moved to core/exported. SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily enough didn't use it so we could just break this dependency. BUG=708879 Review-Url: https://codereview.chromium.org/2833693002 Cr-Commit-Position: refs/heads/master@{#468274} Committed: https://chromium.googlesource.com/chromium/src/+/2ebe3671d78db19aa97d2c4950069c1ff837c4a5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Fix merge issue. #

Patch Set 4 : Fix merge issue. #

Patch Set 5 : Make SharedWorkerRepositoryClient CORE_EXPORTed for windows builds. #

Patch Set 6 : Remove #include of WebFrameClient that was not being used, and caused linker errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -241 lines) Patch
M third_party/WebKit/Source/core/exported/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerRepositoryClient.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +0 lines, -161 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (19 generated)
slangley
3 years, 8 months ago (2017-04-20 04:49:45 UTC) #4
joelhockey
lgtm
3 years, 8 months ago (2017-04-20 04:53:57 UTC) #5
slangley
haraken@ - ptal
3 years, 8 months ago (2017-04-20 04:58:32 UTC) #7
haraken
LGTM https://codereview.chromium.org/2833693002/diff/1/third_party/WebKit/Source/core/exported/BUILD.gn File third_party/WebKit/Source/core/exported/BUILD.gn (right): https://codereview.chromium.org/2833693002/diff/1/third_party/WebKit/Source/core/exported/BUILD.gn#newcode10 third_party/WebKit/Source/core/exported/BUILD.gn:10: "WebAssociatedURLLoaderImpl.cpp", As commented in other CLs, I'd prefer ...
3 years, 8 months ago (2017-04-20 07:38:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833693002/1
3 years, 8 months ago (2017-04-26 06:15:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/255419) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-26 06:18:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833693002/20001
3 years, 8 months ago (2017-04-26 07:19:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/355123)
3 years, 8 months ago (2017-04-26 07:29:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833693002/60001
3 years, 8 months ago (2017-04-26 23:55:30 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/398322)
3 years, 8 months ago (2017-04-27 01:34:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833693002/80001
3 years, 7 months ago (2017-04-28 06:26:52 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/217485)
3 years, 7 months ago (2017-04-28 07:36:50 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833693002/100001
3 years, 7 months ago (2017-05-01 01:29:58 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 03:21:07 UTC) #33
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2ebe3671d78db19aa97d2c495006...

Powered by Google App Engine
This is Rietveld 408576698