Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2833673005: SimpleCache: comment a tricky bit of code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Maks Orlovich
Modified:
3 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

SimpleCache: comment a tricky bit of code. (Also flip conditional around since I think it makes it a little easier to unstand what the special case is). BUG= Review-Url: https://codereview.chromium.org/2833673005 Cr-Commit-Position: refs/heads/master@{#466131} Committed: https://chromium.googlesource.com/chromium/src/+/dbf935c161d8a9e8da1a1f4bfa9c407967dd7db3

Patch Set 1 #

Patch Set 2 : Just trying to avoid bogus dependency due to earlier screw up. Identical bits #

Messages

Total messages: 9 (5 generated)
Maks Orlovich
I think you probably have the perfect level of familiarity with the code to judge ...
3 months ago (2017-04-20 18:24:58 UTC) #2
jkarlin
lgtm!
3 months ago (2017-04-20 18:28:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833673005/20001
3 months ago (2017-04-20 18:32:56 UTC) #6
commit-bot: I haz the power
3 months ago (2017-04-20 21:09:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbf935c161d8a9e8da1a1f4bfa9c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973