Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 2833603002: Revert of Plumb activation time to main (Closed)

Created:
3 years, 8 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 8 months ago
CC:
blink-reviews, brianderson, cc-bugs_chromium.org, chromium-reviews, enne (OOO), kinuko+watch, scheduler-bugs_chromium.org, Sami, vmpstr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plumb activation time to main (patchset #16 id:280001 of https://codereview.chromium.org/2778223005/ ) Reason for revert: Failure observed in LayerTreeHostProxyTestActivationTime.RunMultiThread_DelegatingRenderer https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F59244%2F%2B%2Frecipes%2Fsteps%2Fcc_unittests%2F0%2Flogs%2FLayerTreeHostProxyTestActivationTime.RunMultiThread_DelegatingRenderer%2F0 Original issue's description: > Plumb activation time in cc to Blink Scheduler in Main > > BUG=657826, 657825 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2778223005 > Cr-Commit-Position: refs/heads/master@{#465701} > Committed: https://chromium.googlesource.com/chromium/src/+/9a2eb472fde51de48c095c9c208101c534ac211e TBR=brianderson@chromium.org,ccameron@chromium.org,alexclarke@chromium.org,miguelg@chromium.org,tedchoc@chromium.org,panicker@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657826, 657825 Review-Url: https://codereview.chromium.org/2833603002 Cr-Commit-Position: refs/heads/master@{#465757} Committed: https://chromium.googlesource.com/chromium/src/+/8aeea939c0f289b85181b6e8fc9c0966451e9369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -258 lines) Patch
M cc/output/begin_frame_args.h View 3 chunks +0 lines, -19 lines 0 comments Download
M cc/output/begin_frame_args.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M cc/output/begin_frame_args_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/scheduler/begin_frame_source.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +1 line, -8 lines 0 comments Download
M cc/scheduler/scheduler.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 30 chunks +30 lines, -30 lines 0 comments Download
M cc/test/begin_frame_args_test.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_proxy.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M content/browser/compositor/gpu_vsync_begin_frame_source.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 23 chunks +70 lines, -70 lines 0 comments Download
M ui/android/window_android.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Roger McFarlane (Chromium)
Created Revert of Plumb activation time to main
3 years, 8 months ago (2017-04-19 21:21:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833603002/1
3 years, 8 months ago (2017-04-19 21:22:02 UTC) #3
panicker
LGTM. For the roll forward, could you indicate how to run the failing test? Is ...
3 years, 8 months ago (2017-04-19 21:26:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8aeea939c0f289b85181b6e8fc9c0966451e9369
3 years, 8 months ago (2017-04-19 21:27:15 UTC) #7
ojan
Here's the first failing run. It failed twice in a row, so it's probably not ...
3 years, 8 months ago (2017-04-19 21:45:48 UTC) #9
Roger McFarlane (Chromium)
On 2017/04/19 21:26:42, panicker wrote: > LGTM. > For the roll forward, could you indicate ...
3 years, 8 months ago (2017-04-19 21:47:39 UTC) #10
panicker
On 2017/04/19 21:47:39, Roger McFarlane (Chromium) wrote: > On 2017/04/19 21:26:42, panicker wrote: > > ...
3 years, 8 months ago (2017-04-19 23:00:32 UTC) #11
panicker
3 years, 8 months ago (2017-04-19 23:22:12 UTC) #12
Message was sent while issue was closed.
On 2017/04/19 23:00:32, panicker wrote:
> On 2017/04/19 21:47:39, Roger McFarlane (Chromium) wrote:
> > On 2017/04/19 21:26:42, panicker wrote:
> > > LGTM.
> > > For the roll forward, could you indicate how to run the failing test? 
> > > Is it flaky or failing consistently? Did it run on Presubmit?
> > > Thanks!
> > 
> > this should do the trick...
> > 
> > cc_unittests
> >
>
--gtest_filter=LayerTreeHostProxyTestActivationTime.RunMultiThread_DelegatingRenderer
> > 
> > That runs only the test that failed.
> > 
> > The command on the bot that ran the entire suite was:
> > 
> > cc_unittests.exe --brave-new-test-launcher --test-launcher-bot-mode
> > --test-launcher-summary-output=e:\b\swarm_slave\w\iomwmbws\output.json
> 
> That's the test I added and it passes for me locally and on other platforms
(in
> trybot).
> so question is whether it fails consistently on windows or is flaky.

Looks like it fails consistently on win7 (and win_chromium_dbg_ng is not
included in the presubmit run)

Powered by Google App Engine
This is Rietveld 408576698