Remove unneeded abstractions and simplify RecordingImageBufferSurface

third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

Index: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
diff --git a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
index 9a11dc0c4c65cd7fa095983d58f7f382be0630a2..24ae327db76be58fba030795714974c22836eec7 100644
--- a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
+++ b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
@@ -90,9 +90,8 @@ PassRefPtr<Image> CSSPaintDefinition::Paint(
   DCHECK(layout_object.GetNode());
 
   PaintRenderingContext2D* rendering_context = PaintRenderingContext2D::Create(
-      ImageBuffer::Create(WTF::WrapUnique(
-          new RecordingImageBufferSurface(size, nullptr /* fallbackFactory */,

[danakj, 2017/04/19 21:16:36]

This nullptr would have triggered a DCHECK and crash if fallback happened, and
would prevent fallback due to kExpensiveRecordingStackDepth. Is this needed, cuz
I could pass a bool here to do what the nullptr used to if you think it is?

-                                          has_alpha_ ? kNonOpaque : kOpaque))),
+      ImageBuffer::Create(WTF::WrapUnique(new RecordingImageBufferSurface(
+          size, has_alpha_ ? kNonOpaque : kOpaque))),
       has_alpha_, zoom);
   PaintSize* paint_size = PaintSize::Create(specified_size);
   StylePropertyMapReadonly* style_map =