Remove unneeded abstractions and simplify RecordingImageBufferSurface

third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/csspaint/CSSPaintDefinition.h"
 
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8BindingMacros.h"
 #include "bindings/core/v8/V8ObjectConstructor.h"
@@ skipping 72 matching lines @@
   v8::Local<v8::Object> instance = instance_.NewLocal(isolate);
 
   // We may have failed to create an instance class, in which case produce an
   // invalid image.
   if (IsUndefinedOrNull(instance))
     return nullptr;
 
   DCHECK(layout_object.GetNode());
 
   PaintRenderingContext2D* rendering_context = PaintRenderingContext2D::Create(
-      ImageBuffer::Create(WTF::WrapUnique(
-          new RecordingImageBufferSurface(size, nullptr /* fallbackFactory */,

[danakj, 2017/04/19 21:16:36]

This nullptr would have triggered a DCHECK and crash if fallback happened, and
would prevent fallback due to kExpensiveRecordingStackDepth. Is this needed, cuz
I could pass a bool here to do what the nullptr used to if you think it is?

-                                          has_alpha_ ? kNonOpaque : kOpaque))),
+      ImageBuffer::Create(WTF::WrapUnique(new RecordingImageBufferSurface(
+          size, has_alpha_ ? kNonOpaque : kOpaque))),
       has_alpha_, zoom);
   PaintSize* paint_size = PaintSize::Create(specified_size);
   StylePropertyMapReadonly* style_map =
       FilteredComputedStylePropertyMap::Create(
           CSSComputedStyleDeclaration::Create(layout_object.GetNode()),
           native_invalidation_properties_, custom_invalidation_properties_,
           layout_object.GetNode());
 
   v8::Local<v8::Value> argv[] = {
       ToV8(rendering_context, script_state_->GetContext()->Global(), isolate),
@@ skipping 33 matching lines @@
   v8::Local<v8::Object> paint_instance;
   if (V8ObjectConstructor::NewInstance(isolate, constructor)
           .ToLocal(&paint_instance)) {
     instance_.Set(isolate, paint_instance);
   }
 
   did_call_constructor_ = true;
 }
 
 }  // namespace blink