Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2833553002: Revert of [Prerender] Restore request priorities when swapped in (Closed)

Created:
3 years, 8 months ago by ojan
Modified:
3 years, 8 months ago
Reviewers:
droger
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of [Prerender] Restore request priorities when swapped in (patchset #1 id:1 of https://codereview.chromium.org/2832473002/ ) Reason for revert: Caused compile failures on Mac and Windows Beta official desktop continuous waterfall. https://bugs.chromium.org/p/chromium/issues/detail?id=713223 Original issue's description: > [Prerender] Restore request priorities when swapped in > > Requests from prerendered contents have a IDLE priority, in order not to slow > down visible pages. > However, when the prerendered contents become visible, the request priorities > were not reset back to their correct values, leading to bad prerendering > performance. > > In this CL, the priority management for prerender requests is moved to the > PrerenderResourceThrottle/PrerendereContents. > The original priorities are stored in the throttle, and restored when the > prerender contents swaps in. > A new public function is added to ResourceDispatcherHost to update a request > priority, and its implementation reuses the existing code that updates the image > priorities. > > The prerender contents keeps a list of all the network resources that were > started while the prerender is hidden. If this proves to be too large, pruning > the list when responses are received should be doable. > > BUG=705955 > > Review-Url: https://codereview.chromium.org/2807163002 > Cr-Commit-Position: refs/heads/master@{#464728} > (cherry picked from commit d3bc6148c7f0d2695ec2ca74652d996e2c4f5a6e) > > Review-Url: https://codereview.chromium.org/2832473002 . > Cr-Commit-Position: refs/branch-heads/3071@{#48} > Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/d4b0c9f58ec981f98342cb8438da1a69bb489a06 TBR=droger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705955 Review-Url: https://codereview.chromium.org/2833553002 Cr-Commit-Position: refs/branch-heads/3071@{#58} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e8cd36ed2928f6e667386a687068e6a1de4124fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -294 lines) Patch
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 14 chunks +30 lines, -151 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 3 chunks +4 lines, -14 lines 0 comments Download
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle.h View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle.cc View 5 chunks +1 line, -42 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.h View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 5 chunks +18 lines, -27 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/loader/resource_scheduler.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M content/public/browser/resource_dispatcher_host.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ojan
Created Revert of [Prerender] Restore request priorities when swapped in
3 years, 8 months ago (2017-04-19 18:22:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833553002/1
3 years, 8 months ago (2017-04-19 18:22:50 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:23:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8cd36ed2928f6e667386a687068...

Powered by Google App Engine
This is Rietveld 408576698